This repository was archived by the owner on Dec 31, 2024. It is now read-only.
List formatting refactor and places/place feature - #218
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #218 +/- ##
==========================================
+ Coverage 96.89% 96.92% +0.02%
==========================================
Files 8 8
Lines 547 552 +5
==========================================
+ Hits 530 535 +5
Misses 17 17
Continue to review full report at Codecov.
|
Contributor
Author
|
Oops, I guess it's done now. |
kazupon
approved these changes
Aug 28, 2017
kazupon
left a comment
Owner
There was a problem hiding this comment.
Thank you for your PR!
Perfect! 💯
Thanks!
This was referenced Aug 28, 2017
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Item 2 depends on item 1, combined in one PR but separate commits.
Commits were rebased so they comes after the codecov report.