fix: keep Number Field invalid ring visible when blurred#101
Open
focus0802 wants to merge 1 commit into
Open
Conversation
|
@focus0802 is attempting to deploy a commit to the Keenthemes Team on Vercel. A member of the Team first needs to authorize it. |
focus0802
marked this pull request as draft
July 19, 2026 06:12
focus0802
marked this pull request as ready for review
July 20, 2026 14:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Keep Number Field invalid styling visible after focus leaves the control, matching the existing Input, Select, and Input Group behavior.
Root cause
numberFieldGroupVariantsset the destructive ring color but did not set an invalid ring width. The only ring width was attached tofocus-within:ring-3, so an invalid blurred Number Field rendered only a destructive 1px border.The descendant invalid selectors were also scoped to
focus-within, which meant an invalidNumberFieldInputcould not keep the visual Group in its invalid state after focus moved away.Changes
aria-invalid:ring-3for Group-level invalid state.has-aria-invalid:*andhas-aria-invalid:ring-3so a descendant invalid input styles the Group while blurred.Verification
pnpm registry:allpasses: 2,462 registry items verified across 16 styles.pnpm buildpasses, including registry production generation and Next.js production build.pnpm lintandpnpm typecheckcurrently report pre-existing repository-wide errors unrelated to this change.