Allow tuple destructuring in matches#649
Open
kengorab wants to merge 7 commits into
Open
Conversation
This introduces a new syntax for matching on tuple values, using nested tuple destructuring. For now, this just accounts for the parsing changes in addition to a sizeable refactoring/cleanup in the typechecker (which does not yet support tuple match cases).
This took a LONG time to get right, and it resulted in multiple iterations of trying out various strategies. In the end, I refactored the way match-cases are typechecked across the board in order to support this, as well as future use cases that will be coming (soon, probably).
Add a specific MatchCasePossibility to represent unbounded cases, for example integers, floats, strings, structs, etc. Technically a struct which consists solely of bounded cases (recursively) is itself bounded, but we don't have support for nested match patterns in this way (yet).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This introduces a new syntax for matching on tuple values, using nested tuple destructuring. For now, this just accounts for the parsing changes in addition to a sizeable refactoring/cleanup in the typechecker (which does not yet support tuple match cases).