Warn on activation script staleness - #454
Merged
jadeallenx merged 2 commits intoAug 24, 2023
Merged
Conversation
This was referenced Aug 15, 2023
Collaborator
|
As mentioned, this needs a rebase now but overall looks great |
We assume the update is to a newer version, always, but the warning doesn't really care about that
(and we're looking for the system-wide kerl)
paulo-ferraz-oliveira
marked this pull request as ready for review
August 22, 2023 23:23
Contributor
Author
|
Rebased on top of |
jadeallenx
approved these changes
Aug 24, 2023
Collaborator
|
I wish we could consolidate these activation scripts because they're so similiar in so many ways... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #175.
NOTE: not to be merged yet, since this builds on top of #452. I'll rebase once the other one gets approved+merged.