Skip to content

Add fish shell completion support - #543

Merged
paulo-ferraz-oliveira merged 5 commits into
kerl:masterfrom
Bryan2333:fish_completion
Aug 24, 2024
Merged

paulo-ferraz-oliveira merged 5 commits into
kerl:masterfrom
Bryan2333:fish_completion

Conversation

@Bryan2333

Copy link
Copy Markdown
Contributor

Description

I open this pull request to add fish shell completion support.

@Bryan2333
Bryan2333 marked this pull request as draft July 31, 2024 08:34
@Bryan2333
Bryan2333 marked this pull request as ready for review July 31, 2024 08:38
@paulo-ferraz-oliveira

Copy link
Copy Markdown
Contributor

@Bryan2333, thanks for this. Really cool.

  1. is there a way to statically check this (and/or format) as we do with shellcheck and shfmt for e.g. Bash?

  2. does it cover all commands? Or is something missing?

@Bryan2333

Copy link
Copy Markdown
Contributor Author
  1. There is no linter for fish shell script so far. If we need to check the syntax of the script, I think the only way is to run the script directly.
  2. Yes, it cover all commands of kerl.

@paulo-ferraz-oliveira

paulo-ferraz-oliveira commented Aug 23, 2024

Copy link
Copy Markdown
Contributor

Yeah, I installed fish ran fish -n on the file and there were no errors. Could you update the README with instructions similar to bash/zsh's (I'll post the md below, for copy-paste ease). Thanks.

### Command-line completion

Optionally, download and install `kerl`'s:

- `bash_completion` file from <https://github.com/kerl/kerl/raw/master/bash_completion/kerl>
- `zsh_completion` file from <https://github.com/kerl/kerl/raw/master/zsh_completion/_kerl>
- `fish-completion` file from <https://github.com/kerl/kerl/raw/master/fish_completion/kerl.fish>

depending on your preferred shell.

Comment thread fish_completion/kerl.fish Outdated
Comment thread fish_completion/kerl.fish
Bryan2333 and others added 3 commits August 24, 2024 09:50
@paulo-ferraz-oliveira

Copy link
Copy Markdown
Contributor

Merging... thanks much for this. If you need a release soonish feel free to let us know.

@paulo-ferraz-oliveira
paulo-ferraz-oliveira merged commit 47c1a37 into kerl:master Aug 24, 2024
@Bryan2333
Bryan2333 deleted the fish_completion branch August 24, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants