Skip to content

Unify fundamental terms throughout the application#11304

Merged
abstractj merged 1 commit intokeycloak:mainfrom
mabartos:KC-11301
Apr 29, 2022
Merged

Unify fundamental terms throughout the application#11304
abstractj merged 1 commit intokeycloak:mainfrom
mabartos:KC-11301

Conversation

@mabartos
Copy link
Contributor

@mabartos mabartos commented Apr 14, 2022

Fixes #11301

@andymunro @tyandor Could you please take a look at this? Thank you.

@tyandor
Copy link
Contributor

tyandor commented Apr 14, 2022

Thanks for the heads up @mabartos! Changes we made here were requested by UX but if that creates inconsistency definitely not a problem to change back.

Copy link
Contributor

@tyandor tyandor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@andymunro
Copy link
Contributor

Generally our documentation always use log in rather than sign in. I think it is a good topic to suggest for the whole documentation set, but not for one PR.

@mabartos
Copy link
Contributor Author

@andymunro I'm not sure about this. In PR #10748, there were some changes related to those terms and I don't see any benefit by changing it there, rather the opposite. The account console was using the Sign in term before those changes[1] and it was consistent with the login screens. The documentation is more separated than the login and account screens together. I think this PR is relevant.

[1] https://github.com/keycloak/keycloak/pull/10748/files#diff-c9960d63791e169b1bd22eaa9d37a256f2e76c3738a9aa35365f1f62e9ec0ccaL98-L104

@andymunro
Copy link
Contributor

Thanks @mabartos. Okay, I see either way, there is some inconsistency with the UI or the documentation. If so, I agree with your suggested changes.

@ahus1 ahus1 added area/account/ui kind/bug Categorizes a PR related to a bug labels Apr 20, 2022
@abstractj
Copy link
Contributor

Adding @ssilvert here considering the impact in the UI

@abstractj abstractj merged commit d931156 into keycloak:main Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/account/ui kind/bug Categorizes a PR related to a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unify fundamental terms throughout the application

6 participants