Keycloak 12624 nullpointer during OIDC logout client disabled#13424
Conversation
…idc-logout-client-disabled
|
My apologies, I only realized it after I invoked the Intellij formatter and that's why some more changes are showing. These are formatting changes. |
mposolda
left a comment
There was a problem hiding this comment.
@marcelomrwin Thanks for the PR!
I've added one inline comment (Sorry if I was unclear when we had a chat about this today morning. Hope it is clearer from the comment)
Besides that, is it possible to write automted test also for the scenario when the account client is disabled? I am thinking about the scenario like:
- User login
- Client
accountwill be disabled - Logout is triggered by going to the LogoutEndpoint without any parameters (In case that none of
id_token_hintandclient_idparameters is used, then the "System client" is used as the client during logout. And this system client is theaccountclient). See calls toSystemClientUtil.getSystemClientfor more details
Test scenario created and tested. Working as expected. I await your appreciation to ensure that the understanding was correct. |
…idc-logout-client-disabled
…idc-logout-client-disabled
mposolda
left a comment
There was a problem hiding this comment.
@marcelomrwin Thanks Marcelo for the updates and for the automated test!
Fixes #12624