Skip to content

Place Java setup in re-usable workflow file - #17541

Merged
stianst merged 2 commits into
keycloak:mainfrom
jonkoops:reusable-java-setup
Jul 26, 2023
Merged

Place Java setup in re-usable workflow file#17541
stianst merged 2 commits into
keycloak:mainfrom
jonkoops:reusable-java-setup

Conversation

@jonkoops

@jonkoops jonkoops commented Mar 9, 2023

Copy link
Copy Markdown
Contributor

Creates a re-usable workflow to set up Java (similar to the NPM setup). This allow us to remove some repeated code for places were we want to use the project default Java version and distribution.

@jonkoops jonkoops added area/ci Indicates an issue on the CI kind/task labels Mar 9, 2023
@jonkoops
jonkoops requested review from ahus1 and stianst March 9, 2023 14:28
@jonkoops
jonkoops requested a review from a team as a code owner March 9, 2023 14:28
@jonkoops jonkoops self-assigned this Mar 9, 2023
ahus1
ahus1 previously approved these changes Mar 13, 2023

@ahus1 ahus1 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for consolidating the Java setup!

@jonkoops
jonkoops force-pushed the reusable-java-setup branch 3 times, most recently from 0effd03 to b493fb0 Compare May 30, 2023 11:50
@jonkoops
jonkoops force-pushed the reusable-java-setup branch from b493fb0 to 4cd3496 Compare May 30, 2023 11:54
@jonkoops
jonkoops requested a review from ahus1 May 30, 2023 11:57
@cypress

cypress Bot commented May 30, 2023

Copy link
Copy Markdown

3 flaky tests on run #8245 ↗︎

0 527 48 0 Flakiness 3

Details:

Merge 2a13036 into 2267352...
Project: Keycloak Admin UI Commit: 57d2256163 ℹ️
Status: Passed Duration: 16:04 💡
Started: Jul 26, 2023 6:32 AM Ended: Jul 26, 2023 6:48 AM
Flakiness  authentication_test.spec.ts • 1 flaky test • chrome

View Output Video

Test Artifacts
Authentication test > should add a condition Output Screenshots
Flakiness  realm_settings_events_test.spec.ts • 1 flaky test • chrome

View Output Video

Test Artifacts
Realm settings events tab tests > Should remove event from event listener Output Screenshots
Flakiness  realm_settings_general_tab_test.spec.ts • 1 flaky test • chrome

View Output Video

Test Artifacts
Realm settings general tab tests > Test all general tab switches Output Screenshots

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

Comment thread .github/actions/integration-test-setup/action.yml
@stianst stianst assigned stianst and unassigned jonkoops Jul 26, 2023
@stianst
stianst enabled auto-merge (squash) July 26, 2023 09:06
@stianst
stianst merged commit 2f617bd into keycloak:main Jul 26, 2023
@jonkoops
jonkoops deleted the reusable-java-setup branch July 27, 2023 09:35
stianst added a commit to stianst/keycloak that referenced this pull request Sep 4, 2023
Co-authored-by: Stian Thorgersen <stianst@gmail.com>
stianst added a commit that referenced this pull request Sep 4, 2023
Co-authored-by: Stian Thorgersen <stianst@gmail.com>
This was referenced Sep 6, 2023
@stianst stianst mentioned this pull request Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/ci Indicates an issue on the CI kind/task

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants