lazy populate the treeview for groups by edewit · Pull Request #21520 · keycloak/keycloak

edewit · 2023-07-07T18:26:06Z

Fetching of the subgroups is now paginates in the tree and the detail view

subgroup pagination in the treeview

tree is now lazy populated on select

fixes: #19954

ssilvert

Looks good. I'm going to try it out later.

js/apps/admin-ui/src/groups/GroupsSection.tsx

ghost

Unreported flaky test detected, please review

ghost · 2023-07-07T19:52:46Z

Unreported flaky test detected

If the below flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.model.session.OfflineSessionPersistenceTest#testPersistenceMultipleNodesClientSessionsAtRandomNode

Keycloak CI - Store Model Tests

java.lang.AssertionError: Execution didn't complete: java.lang.RuntimeException: org.infinispan.util.concurrent.TimeoutException: ISPN000658: Initial state transfer timed out for cache offlineSessions on node-9
	at org.junit.Assert.fail(Assert.java:89)
	at org.keycloak.testsuite.model.KeycloakModelTest.inIndependentFactories(KeycloakModelTest.java:436)
	at org.keycloak.testsuite.model.session.OfflineSessionPersistenceTest.testPersistenceMultipleNodesClientSessionsAtRandomNode(OfflineSessionPersistenceTest.java:249)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
...

Report flaky test

ssilvert

This doesn't fix the problem for me. Did you try to partial import the json attached to the issue? Import works fine (you just have to let it finish). But then I try to go to the Groups section and it hangs.

On a more minor note, the show/hide works well, but I think the "show" icon should be a right arrow instead of a hamburger menu.

ssilvert

I've tested the latest revision on this PR and it works great. Still needs code review.

jonkoops · 2023-07-26T09:32:31Z

@ssilvert I think the tests are still failing on this one, but I will do quick rebase to make sure.

ghost

Unreported flaky test detected, please review

ghost · 2023-07-26T12:31:59Z

Unreported flaky test detected

If the below flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.webauthn.account.WebAuthnTransportLocaleTest#multipleTransports

Keycloak CI - WebAuthn IT (chrome)

java.lang.AssertionError: Expected OIDCLogin but was  (https://localhost:8543/auth/realms/test/protocol/openid-connect/auth?client_id=account-console&redirect_uri=https%3A%2F%2Flocalhost%3A8543%2Fauth%2Frealms%2Ftest%2Faccount%2F%23%2Fsecurity%2Fsigningin&state=f2eaf2f8-49d9-4767-8e10-50d381480f3b&response_mode=fragment&response_type=code&scope=openid&nonce=bd40d161-df0d-454e-8d62-5dbed66e831e&code_challenge=fd6gg3ma-YcwS3i0OKDDTQCUz5h33PzuNkLcWQW5HOE&code_challenge_method=S256)
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.keycloak.testsuite.page.AbstractPage.assertCurrent(AbstractPage.java:110)
	at jdk.internal.reflect.GeneratedMethodAccessor613.invoke(Unknown Source)
...

Report flaky test

jonkoops · 2023-07-27T09:29:24Z

Looks like it has to do with the changes introduced by Erik, we'll have to wait until he's back next week.

alice-wondered · 2023-08-02T13:52:44Z

We have been working on the same idea with a slightly different direction by expanding out the storage implementations and then updating the surrounding utility and resource classes to account for pagination. It isn't in a final state yet but since comments mention issue not being solved curious if it would be welcome here: main...Redhat-Alice:keycloak:subgroup-model-expansion

cypress · 2023-08-04T10:57:19Z

1 flaky tests on run #8403 ↗︎

0	527	48	0	1

Details:

Merge `3d4795c` into `5e21ff5`...
Project: Keycloak Admin UI	Commit: `6351abdc59 ℹ️`
Status: Passed	Duration: 17:36 💡
Started: Aug 4, 2023 6:55 PM	Ended: Aug 4, 2023 7:12 PM

cypress/e2e/authentication_test.spec.ts • 1 flaky test • chrome

View Output Video

Test		Artifacts
Authentication test > should add a condition		`Output` `Screenshots`

_{This comment has been generated by cypress-bot as a result of this
project's GitHub integration settings.}

zwitter1 · 2023-08-04T15:18:17Z

Just a heads up. I had a few issues in testing this branch. The pagination on the left side wasn't working when I'd switch the count to 10 per page.

I also don't get the caret on the dropdowns for groups with subgroups until I click on the group.

ssilvert · 2023-08-04T18:45:56Z

We have been working on the same idea with a slightly different direction by expanding out the storage implementations and then updating the surrounding utility and resource classes to account for pagination. It isn't in a final state yet but since comments mention issue not being solved curious if it would be welcome here: main...Redhat-Alice:keycloak:subgroup-model-expansion

I believe this is solved now and we intend to merge the PR soon. If you want to suggest an improvement, go ahead and create an enhancement request or discussion.

fixes: keycloak#19954

This reverts commit 451e96a652915cecbb2ca3d3901acdeb1a20104e.

This reverts commit b8efdf2e550dd92dab0b9244314e438f933c14f1.

This reverts commit a39f9b60e1ae4f3e59339b6878aecbbe8d90a6f7.

* added lazy parameter fixes: keycloak#19954 * changed to only have the parameter * fixed merge errors * removed the `lazy` and now add subgroups on select * lint * fixed prettier * fixed nullpointer * fixed member tab

Fixes: #19954

edewit requested a review from a team as a code owner July 7, 2023 18:26

ghost added the team/ui label Jul 7, 2023

ssilvert reviewed Jul 7, 2023

View reviewed changes

js/apps/admin-ui/src/groups/GroupsSection.tsx Outdated Show resolved Hide resolved

js/apps/admin-ui/src/groups/GroupsSection.tsx Outdated Show resolved Hide resolved

ghost added the flaky-test label Jul 7, 2023

This was referenced Jul 7, 2023

Flaky test: org.keycloak.testsuite.admin.authentication.FlowTest#testAddRemoveFlow #20763

Closed

Flaky test: org.keycloak.testsuite.webauthn.account.WebAuthnSigningInTest#notDisplayAvailableAuthenticatorsPasswordless #20476

Closed

ghost reviewed Jul 7, 2023

View reviewed changes

edewit requested a review from ssilvert July 10, 2023 06:10

edewit force-pushed the issue-19954 branch from f98b156 to e5086c5 Compare July 10, 2023 13:59

edewit requested a review from a team as a code owner July 10, 2023 13:59

ssilvert force-pushed the issue-19954 branch from e5086c5 to 769d689 Compare July 10, 2023 17:26

ssilvert requested changes Jul 10, 2023

View reviewed changes

edewit closed this Jul 11, 2023

edewit reopened this Jul 11, 2023

edewit requested a review from ssilvert July 13, 2023 08:19

edewit force-pushed the issue-19954 branch from ab34819 to ccb2fba Compare July 13, 2023 08:35

edewit changed the title ~~added lazy parameter~~ lazy populate the treeview for groups Jul 13, 2023

ghost mentioned this pull request Jul 13, 2023

Flaky test: org.keycloak.testsuite.forms.ResetPasswordTest#resetPasswordLink #21422

Closed

ssilvert reviewed Jul 25, 2023

View reviewed changes

ssilvert mentioned this pull request Jul 25, 2023

Pagination of groups works incorrectly #21949

Closed

2 tasks

jonkoops force-pushed the issue-19954 branch from 56fdb6b to e64c6a4 Compare July 26, 2023 09:32

ghost reviewed Jul 26, 2023

View reviewed changes

edewit enabled auto-merge (squash) August 4, 2023 08:08

edewit and others added 14 commits August 4, 2023 14:46

added lazy parameter

01628f8

fixes: keycloak#19954

changed to only have the parameter

4154dbc

fixed merge errors

ba811c7

removed the lazy and now add subgroups on select

e63a4c8

lint

84a3c1b

fixed prettier

550edd2

fixed nullpointer

490d3be

fixed member tab

41807d7

fetch current group

f75d48a

Revert "fixed member tab"

d8ff4e9

This reverts commit 451e96a652915cecbb2ca3d3901acdeb1a20104e.

Revert "fetch current group"

f13273a

This reverts commit b8efdf2e550dd92dab0b9244314e438f933c14f1.

better fix members and attiributes

621f7a1

Revert "Revert "fixed member tab""

5f88a08

This reverts commit a39f9b60e1ae4f3e59339b6878aecbbe8d90a6f7.

fix a11y

3d4795c

ssilvert force-pushed the issue-19954 branch from 19f8398 to 3d4795c Compare August 4, 2023 18:46

ssilvert approved these changes Aug 4, 2023

View reviewed changes

edewit merged commit 3396198 into keycloak:main Aug 4, 2023

edewit deleted the issue-19954 branch August 5, 2023 07:12

eatikrh mentioned this pull request Aug 8, 2023

Extend DatasetResourceProvider to create hierarchical groups with many subgroups keycloak/keycloak-benchmark#471

Closed

jonkoops added a commit that referenced this pull request Aug 23, 2023

lazy populate the treeview for groups (#21520) (#22656)

ef0f8ea

Fixes: #19954

This was referenced Sep 4, 2023

sync github #22926

Closed

testsuite cnditional #23002

Closed

release/22.0 #23125

Closed

stianst mentioned this pull request Nov 14, 2023

eap docs #24733

Closed

stianst mentioned this pull request May 6, 2024

Ignore github links when checking links #29291

Merged

Conversation

edewit commented Jul 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ssilvert left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ghost left a comment

Choose a reason for hiding this comment

Uh oh!

ghost commented Jul 7, 2023

Unreported flaky test detected

org.keycloak.testsuite.model.session.OfflineSessionPersistenceTest#testPersistenceMultipleNodesClientSessionsAtRandomNode

Uh oh!

ssilvert left a comment

Choose a reason for hiding this comment

Uh oh!

ssilvert left a comment

Choose a reason for hiding this comment

Uh oh!

jonkoops commented Jul 26, 2023

Uh oh!

ghost left a comment

Choose a reason for hiding this comment

Uh oh!

ghost commented Jul 26, 2023

Unreported flaky test detected

org.keycloak.testsuite.webauthn.account.WebAuthnTransportLocaleTest#multipleTransports

Uh oh!

jonkoops commented Jul 27, 2023

Uh oh!

alice-wondered commented Aug 2, 2023

Uh oh!

cypress bot commented Aug 4, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

1 flaky tests on run #8403 ↗︎

Uh oh!

zwitter1 commented Aug 4, 2023

Uh oh!

ssilvert commented Aug 4, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

edewit commented Jul 7, 2023 •

edited

Loading

cypress bot commented Aug 4, 2023 •

edited

Loading