Add Java Distribution IT for Windows by pedroigor · Pull Request #21675 · keycloak/keycloak

pedroigor · 2023-07-13T13:02:20Z

No description provided.

cypress · 2023-07-13T13:54:56Z

Passing run #8074 ↗︎

0	527	48	0	0

Details:

Merge `873965e` into `8045570`...
Project: Keycloak Admin UI	Commit: `449aaa2de7 ℹ️`
Status: Passed	Duration: 16:25 💡
Started: Jul 13, 2023 8:23 PM	Ended: Jul 13, 2023 8:40 PM

_{This comment has been generated by cypress-bot as a result of this
project's GitHub integration settings.}

ghost

Unreported flaky test detected, please review

ghost · 2023-07-13T15:19:43Z

Unreported flaky test detected

If the below flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.script.DeployedScriptAuthenticatorTest#testScriptAuthenticatorNotAvailable

Keycloak CI - Java Distribution IT (windows-latest - temurin - 19)

jakarta.ws.rs.NotFoundException: HTTP 404 Not Found
	at org.jboss.resteasy.client.jaxrs.internal.ClientInvocation.handleErrorStatus(ClientInvocation.java:242)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.extractors.DefaultEntityExtractorFactory$3.extractEntity(DefaultEntityExtractorFactory.java:41)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.ClientInvoker.invokeSync(ClientInvoker.java:136)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.ClientInvoker.invoke(ClientInvoker.java:103)
...

Report flaky test

org.keycloak.testsuite.script.DeployedScriptAuthenticatorTest#loginShouldWorkWithScriptAuthenticator

Keycloak CI - Java Distribution IT (windows-latest - temurin - 19)

java.lang.AssertionError: expected:<201> but was:<404>
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.failNotEquals(Assert.java:835)
	at org.junit.Assert.assertEquals(Assert.java:647)
	at org.junit.Assert.assertEquals(Assert.java:633)
...

jakarta.ws.rs.NotFoundException: HTTP 404 Not Found
	at org.jboss.resteasy.client.jaxrs.internal.ClientInvocation.handleErrorStatus(ClientInvocation.java:242)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.extractors.DefaultEntityExtractorFactory$3.extractEntity(DefaultEntityExtractorFactory.java:41)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.ClientInvoker.invokeSync(ClientInvoker.java:136)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.ClientInvoker.invoke(ClientInvoker.java:103)
...

Report flaky test

org.keycloak.testsuite.script.DeployedScriptAuthenticatorTest#loginShouldFailWithScriptAuthenticator

Keycloak CI - Java Distribution IT (windows-latest - temurin - 19)

java.lang.AssertionError: expected:<201> but was:<404>
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.failNotEquals(Assert.java:835)
	at org.junit.Assert.assertEquals(Assert.java:647)
	at org.junit.Assert.assertEquals(Assert.java:633)
...

jakarta.ws.rs.NotFoundException: HTTP 404 Not Found
	at org.jboss.resteasy.client.jaxrs.internal.ClientInvocation.handleErrorStatus(ClientInvocation.java:242)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.extractors.DefaultEntityExtractorFactory$3.extractEntity(DefaultEntityExtractorFactory.java:41)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.ClientInvoker.invokeSync(ClientInvoker.java:136)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.ClientInvoker.invoke(ClientInvoker.java:103)
...

Report flaky test

ghost

Unreported flaky test detected, please review

ghost · 2023-07-13T18:36:08Z

Unreported flaky test detected

If the below flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.script.DeployedScriptAuthenticatorTest#testScriptAuthenticatorNotAvailable

Keycloak CI - Java Distribution IT (windows-latest - temurin - 19)

jakarta.ws.rs.NotFoundException: HTTP 404 Not Found
	at org.jboss.resteasy.client.jaxrs.internal.ClientInvocation.handleErrorStatus(ClientInvocation.java:242)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.extractors.DefaultEntityExtractorFactory$3.extractEntity(DefaultEntityExtractorFactory.java:41)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.ClientInvoker.invokeSync(ClientInvoker.java:136)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.ClientInvoker.invoke(ClientInvoker.java:103)
...

Report flaky test

org.keycloak.testsuite.script.DeployedScriptAuthenticatorTest#loginShouldWorkWithScriptAuthenticator

Keycloak CI - Java Distribution IT (windows-latest - temurin - 19)

java.lang.AssertionError: expected:<201> but was:<404>
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.failNotEquals(Assert.java:835)
	at org.junit.Assert.assertEquals(Assert.java:647)
	at org.junit.Assert.assertEquals(Assert.java:633)
...

jakarta.ws.rs.NotFoundException: HTTP 404 Not Found
	at org.jboss.resteasy.client.jaxrs.internal.ClientInvocation.handleErrorStatus(ClientInvocation.java:242)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.extractors.DefaultEntityExtractorFactory$3.extractEntity(DefaultEntityExtractorFactory.java:41)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.ClientInvoker.invokeSync(ClientInvoker.java:136)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.ClientInvoker.invoke(ClientInvoker.java:103)
...

Report flaky test

org.keycloak.testsuite.script.DeployedScriptAuthenticatorTest#loginShouldFailWithScriptAuthenticator

Keycloak CI - Java Distribution IT (windows-latest - temurin - 19)

java.lang.AssertionError: expected:<201> but was:<404>
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.failNotEquals(Assert.java:835)
	at org.junit.Assert.assertEquals(Assert.java:647)
	at org.junit.Assert.assertEquals(Assert.java:633)
...

jakarta.ws.rs.NotFoundException: HTTP 404 Not Found
	at org.jboss.resteasy.client.jaxrs.internal.ClientInvocation.handleErrorStatus(ClientInvocation.java:242)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.extractors.DefaultEntityExtractorFactory$3.extractEntity(DefaultEntityExtractorFactory.java:41)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.ClientInvoker.invokeSync(ClientInvoker.java:136)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.ClientInvoker.invoke(ClientInvoker.java:103)
...

Report flaky test

miquelsi

Thanks @pedroigor!

ahus1

Approve as of @miquelsi review

Pepo48 · 2023-07-18T10:21:02Z

@miquelsi a week ago I raised a question about whether the Keycloak project is built on a windows runner. Meanwhile the discussion faded out among other topics, so I'm asking it again before we merge this PR:

In the console output I noticed following OS name: "linux", version: "5.15.0-1041-azure", arch: "amd64", family: "unix". Moreover, just the bash shell is used during build-keycloak action. If I understand correctly, with the current setup the project is not built on Windows, we just extract the maven artifacts that were uploaded during the build action and then we run the subset of tests. Am I right? Or does it somehow use WSL2 feature under the hood?

Because that would explain the fact that in our internal pipelines we currently experience error during the build and here we don't.

I would love to see a keycloak-build action executed natively on a win VM. Otherwise it doesn't give us a sufficient level of certainty - we know about the issues with building the project on the Windows platform, but GH CI does not notify us about them. Or am I out of the scope of this PR?

ahus1 · 2023-07-18T10:21:25Z

Created new unstable test issues, please review:

Maybe it is also a good idea to backport this to KC22.

ahus1 · 2023-07-18T10:39:19Z

@Pepo48 sorry for merging this probably too early. Will wait for your review next time!

Pepo48 · 2023-07-18T10:47:30Z

@ahus1 that's ok, we can eventually resolve it in a follow-up. But let's wait for the clarification from @miquelsi first - I might've easily misunderstood the behaviour and the PR expectations.

Co-authored-by: Miquel Simon <msimonma@redhat.com>

Add Java Distribution IT for Windows

aff4402

pedroigor requested review from a team as code owners July 13, 2023 13:02

pedroigor requested a review from a team July 13, 2023 13:02

ghost added team/core team/cloud-native labels Jul 13, 2023

ghost added the flaky-test label Jul 13, 2023

ghost mentioned this pull request Jul 13, 2023

Flaky test: org.keycloak.testsuite.admin.authentication.FlowTest#testAddRemoveFlow #20763

Closed

ghost reviewed Jul 13, 2023

View reviewed changes

vmuzikar requested review from Pepo48 and miquelsi July 13, 2023 15:37

ghost reviewed Jul 13, 2023

View reviewed changes

Adding sanity check for the distribution on windows

873965e

pedroigor force-pushed the issue-17111 branch from a5d8ff6 to 873965e Compare July 13, 2023 20:00

This was referenced Jul 13, 2023

Flaky test: org.keycloak.testsuite.model.session.SessionTimeoutsTest#testOfflineUserClientIdleTimeoutSmallerThanSessionNoRefresh #20874

Closed

Flaky test: org.keycloak.testsuite.webauthn.account.WebAuthnSigningInTest#displayAvailableAuthenticators #21575

Closed

miquelsi approved these changes Jul 18, 2023

View reviewed changes

ahus1 approved these changes Jul 18, 2023

View reviewed changes

This was referenced Jul 18, 2023

Flaky test: org.keycloak.testsuite.script.DeployedScriptAuthenticatorTest#testScriptAuthenticatorNotAvailable #21778

Closed

Flaky test: org.keycloak.testsuite.script.DeployedScriptAuthenticatorTest#loginShouldWorkWithScriptAuthenticator #21779

Closed

ahus1 mentioned this pull request Jul 18, 2023

Flaky test: org.keycloak.testsuite.script.DeployedScriptAuthenticatorTest#loginShouldFailWithScriptAuthenticator #21780

Closed

ahus1 merged commit d2cdd78 into keycloak:main Jul 18, 2023

stianst pushed a commit to stianst/keycloak that referenced this pull request Sep 4, 2023

Add Java Distribution IT for Windows (keycloak#21675)

b666a22

Co-authored-by: Miquel Simon <msimonma@redhat.com>

stianst pushed a commit that referenced this pull request Sep 4, 2023

Add Java Distribution IT for Windows (#21675)

578af7d

Co-authored-by: Miquel Simon <msimonma@redhat.com>

This was referenced Sep 6, 2023

testsuite cnditional #23002

Closed

release/22.0 #23125

Closed

stianst mentioned this pull request Nov 14, 2023

eap docs #24733

Closed

vmuzikar mentioned this pull request Jan 9, 2024

Run CLI Quarkus tests on Windows in GHA #15305

Closed

stianst mentioned this pull request May 6, 2024

Ignore github links when checking links #29291

Merged

Navigation Menu

Uh oh!

Add Java Distribution IT for Windows - #21675

Add Java Distribution IT for Windows#21675
ahus1 merged 2 commits into
keycloak:mainfrom
pedroigor:issue-17111

pedroigor commented Jul 13, 2023

Uh oh!

cypress Bot commented Jul 13, 2023 •

edited

Loading

Uh oh!

ghost left a comment

Uh oh!

ghost commented Jul 13, 2023

Uh oh!

ghost left a comment

Uh oh!

ghost commented Jul 13, 2023

Uh oh!

miquelsi left a comment

Uh oh!

ahus1 left a comment

Uh oh!

Pepo48 commented Jul 18, 2023 •

edited

Loading

Uh oh!

ahus1 commented Jul 18, 2023

Uh oh!

ahus1 commented Jul 18, 2023

Uh oh!

Pepo48 commented Jul 18, 2023 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

pedroigor commented Jul 13, 2023

Uh oh!

cypress Bot commented Jul 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Passing run #8074 ↗︎

Uh oh!

ghost left a comment

Choose a reason for hiding this comment

Uh oh!

ghost commented Jul 13, 2023

Unreported flaky test detected

org.keycloak.testsuite.script.DeployedScriptAuthenticatorTest#testScriptAuthenticatorNotAvailable

org.keycloak.testsuite.script.DeployedScriptAuthenticatorTest#loginShouldWorkWithScriptAuthenticator

org.keycloak.testsuite.script.DeployedScriptAuthenticatorTest#loginShouldFailWithScriptAuthenticator

Uh oh!

ghost left a comment

Choose a reason for hiding this comment

Uh oh!

ghost commented Jul 13, 2023

Unreported flaky test detected

org.keycloak.testsuite.script.DeployedScriptAuthenticatorTest#testScriptAuthenticatorNotAvailable

org.keycloak.testsuite.script.DeployedScriptAuthenticatorTest#loginShouldWorkWithScriptAuthenticator

org.keycloak.testsuite.script.DeployedScriptAuthenticatorTest#loginShouldFailWithScriptAuthenticator

Uh oh!

miquelsi left a comment

Choose a reason for hiding this comment

Uh oh!

ahus1 left a comment

Choose a reason for hiding this comment

Uh oh!

Pepo48 commented Jul 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ahus1 commented Jul 18, 2023

Uh oh!

ahus1 commented Jul 18, 2023

Uh oh!

Pepo48 commented Jul 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

cypress Bot commented Jul 13, 2023 •

edited

Loading

Pepo48 commented Jul 18, 2023 •

edited

Loading

Pepo48 commented Jul 18, 2023 •

edited

Loading