switches the workaround to JsonNode, which produces a cleaner crd - #21788
Merged
Conversation
vmuzikar
approved these changes
Jul 18, 2023
vmuzikar
left a comment
Contributor
There was a problem hiding this comment.
The workaround works for me. Thanks for the quick fix!
vmuzikar
enabled auto-merge (squash)
July 18, 2023 15:53
vmuzikar
disabled auto-merge
July 18, 2023 16:03
This was referenced Jul 18, 2023
Contributor
Author
|
@vmuzikar confirmed this scenario works through olm - the validation does not care the value is removed as long as the cr's conform. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JsonNode produces the correct crd.
Closes #21739