Skip to content

Remove scheduled from individual workflows - #21847

Merged
ahus1 merged 1 commit into
keycloak:mainfrom
stianst:scheduled-runs
Jul 21, 2023
Merged

Remove scheduled from individual workflows#21847
ahus1 merged 1 commit into
keycloak:mainfrom
stianst:scheduled-runs

Conversation

@stianst

@stianst stianst commented Jul 20, 2023

Copy link
Copy Markdown
Contributor

Trigger all nightly workflows through a single schedule workflow. This has a few benefits compared to what we are doing now:

  • Easier to decide what runs on a nightly basis
  • No schedule in individual workflows, which adds more consistency and prevents all workflows from triggering/skipping on a nightly basis in forks

At the same time it's changing the nightly CI to run a single time instead of multiple times. The testsuite in general is stable enough now that we don't need to run multiple times, and we also now have the ability to see if the workflows fail/retried for PRs.

jonkoops
jonkoops previously approved these changes Jul 20, 2023
Comment thread .github/workflows/schedule-nightly.yml Outdated
jonkoops
jonkoops previously approved these changes Jul 20, 2023
@cypress

cypress Bot commented Jul 20, 2023

Copy link
Copy Markdown

Passing run #8166 ↗︎

0 527 48 0 Flakiness 0

Details:

Merge 376d403 into 2b04008...
Project: Keycloak Admin UI Commit: 5b72d5dab9 ℹ️
Status: Passed Duration: 17:37 💡
Started: Jul 20, 2023 12:43 PM Ended: Jul 20, 2023 1:01 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@ahus1 ahus1 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this change. One thing to note: Once you start workflow with "gh", AFAIK you'll no longer receive email when they fail.

@ahus1
ahus1 merged commit 6220a9d into keycloak:main Jul 21, 2023
stianst added a commit to stianst/keycloak that referenced this pull request Sep 4, 2023
This was referenced Sep 6, 2023
@stianst stianst mentioned this pull request Nov 14, 2023
@stianst
stianst deleted the scheduled-runs branch July 17, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants