Skip to content

Adds a pod list rbac - #21850

Merged
vmuzikar merged 1 commit into
keycloak:release/22.0from
shawkins:pod_rbac
Jul 20, 2023
Merged

Adds a pod list rbac#21850
vmuzikar merged 1 commit into
keycloak:release/22.0from
shawkins:pod_rbac

Conversation

@shawkins

@shawkins shawkins commented Jul 20, 2023

Copy link
Copy Markdown
Contributor

Backport of #21832

Closes #21814

@shawkins
shawkins requested review from a team as code owners July 20, 2023 14:09
@ghost ghost added the team/cloud-native label Jul 20, 2023
@shawkins shawkins mentioned this pull request Jul 20, 2023
Merged
@vmuzikar
vmuzikar enabled auto-merge (squash) July 20, 2023 14:13
@vmuzikar vmuzikar linked an issue Jul 20, 2023 that may be closed by this pull request
Keycloak operator lacks RBAC for Pods #21814
Closed
2 tasks
@vmuzikar
vmuzikar merged commit d655876 into keycloak:release/22.0 Jul 20, 2023
@ghost ghost added the flaky-test label Jul 20, 2023
@ghost

ghost commented Jul 20, 2023

Copy link
Copy Markdown

Unreported flaky test detected

If the below flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.admin.authentication.FlowTest#testAddRemoveFlow

Keycloak CI - New Store IT (chm)

java.lang.AssertionError: deleteFlow should fail for built in flow
	at org.junit.Assert.fail(Assert.java:89)
	at org.keycloak.testsuite.admin.authentication.FlowTest.testAddRemoveFlow(FlowTest.java:110)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
...

Report flaky test

org.keycloak.testsuite.admin.authentication.FlowTest#testAddRemoveFlow

Keycloak CI - New Store IT (hot-rod)

java.lang.AssertionError: deleteFlow should fail for built in flow
	at org.junit.Assert.fail(Assert.java:89)
	at org.keycloak.testsuite.admin.authentication.FlowTest.testAddRemoveFlow(FlowTest.java:110)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
...

Report flaky test

ghost
ghost reviewed Jul 20, 2023
View reviewed changes

@ghost ghost left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

This was referenced Sep 4, 2023
Closed
Closed
Closed
@stianst stianst mentioned this pull request Nov 14, 2023
Closed
@stianst stianst mentioned this pull request May 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vmuzikar vmuzikar vmuzikar approved these changes
+1 more reviewer
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

flaky-test team/cloud-native

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Keycloak operator lacks RBAC for Pods

2 participants

@shawkins @vmuzikar