Skip to content

Avoid calls to Control Plane when the secondary resource is in cache - #21110

Merged
abstractj merged 1 commit into
keycloak:mainfrom
mabartos:api-calls-operator
Jun 22, 2023
Merged

Avoid calls to Control Plane when the secondary resource is in cache#21110
abstractj merged 1 commit into
keycloak:mainfrom
mabartos:api-calls-operator

Conversation

@mabartos

@mabartos mabartos commented Jun 20, 2023

Copy link
Copy Markdown
Member

Closes #21109

@keycloak/cloud-native Could you please check it? Thanks

During reconciliation, we've avoided calls connected to the log message 'Trying to fetch existing Deployment from the API'.
image

@mabartos
mabartos requested review from a team as code owners June 20, 2023 15:23
@shawkins

shawkins commented Jun 20, 2023

Copy link
Copy Markdown
Contributor

LGTM. When this is committed, I'll update #20906 to account for the possiblity that the cached version may not be fresh.

@ghost ghost added the flaky-test label Jun 20, 2023
@ghost ghost mentioned this pull request Jun 20, 2023
Closed
@mabartos

mabartos commented Jun 21, 2023 •
edited
Loading

Copy link
Copy Markdown
Member Author

@shawkins Thanks for the comment. We can basically merge this, prepare the #20906 PR for the case cached version may not be fresh, and then you can complete the task with more comprehensive cache behavior. Is it ok?

Or you want to complete the #20906 without the staleness check and then the bigger task related to these caches with all possible considerations?

@abstractj Could you please retry the Model tests in GHA? Thanks

@shawkins

shawkins commented Jun 21, 2023

Copy link
Copy Markdown
Contributor

Thanks for the comment. We can basically merge this, prepare the #20906 PR for the case cached version may not be fresh, and then you can complete the task with more comprehensive cache behavior. Is it ok?

Good with me.

@abstractj
abstractj enabled auto-merge (rebase) June 22, 2023 12:05
@abstractj
abstractj disabled auto-merge June 22, 2023 13:03
@abstractj
abstractj merged commit 13a463f into keycloak:main Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abstractj abstractj abstractj approved these changes

Assignees

No one assigned

Labels

flaky-test team/cloud-native

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Avoid calls to Control Plane when the secondary resource is in cache

3 participants

@mabartos @shawkins @abstractj