Skip to content

Upgrade to Quarkus 3.2.0.Final and QOSDK 6.2.0 - #21352

Merged
pedroigor merged 2 commits into
keycloak:mainfrom
vmuzikar:quarkus-3.2.0
Jul 3, 2023
Merged

Upgrade to Quarkus 3.2.0.Final and QOSDK 6.2.0#21352
pedroigor merged 2 commits into
keycloak:mainfrom
vmuzikar:quarkus-3.2.0

Conversation

@vmuzikar

Copy link
Copy Markdown
Contributor

Closes #21272

@ghost

ghost commented Jun 30, 2023

Copy link
Copy Markdown

Unreported flaky test detected

If the below flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.model.session.OfflineSessionPersistenceTest#testPersistenceMultipleNodesClientSessionsAtRandomNode

Keycloak CI - Store Model Tests

java.lang.AssertionError: 
threads didn't terminate in time: [main (TIMED_WAITING): locked on java.util.concurrent.FutureTask@38a4708b waiting for 99933 ms blocked for 4396 ms
	at java.base@17.0.7/jdk.internal.misc.Unsafe.park(Native Method)
	at java.base@17.0.7/java.util.concurrent.locks.LockSupport.parkNanos(LockSupport.java:252)
	at java.base@17.0.7/java.util.concurrent.FutureTask.awaitDone(FutureTask.java:444)
...

Report flaky test

@ghost ghost left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@vmuzikar
vmuzikar marked this pull request as ready for review June 30, 2023 14:51
@vmuzikar
vmuzikar requested review from a team as code owners June 30, 2023 14:51
@vmuzikar
vmuzikar requested review from mabartos and shawkins June 30, 2023 14:52
@abstractj

Copy link
Copy Markdown
Contributor

@vmuzikar please make sure to include also #21132. I'd also say that we need to check the dependency versions to make sure they are aligned.

@vmuzikar

Copy link
Copy Markdown
Contributor Author

@abstractj The netty CVE seems like an unrelated issue to Quarkus upgrade. Infinispan 14.0.10 (which we use) appears to be still using Netty 4.1.91. Quarkus is using Infinispan 14.0.9, which we override to 14.0.10. So if we want to bump the Infinispan and/or Netty version, I think we should do it separately.

@vmuzikar

Copy link
Copy Markdown
Contributor Author

I'd also say that we need to check the dependency versions to make sure they are aligned.

Updated bouncycastle and hibernate. Hopefully, we'll align more dependencies as part of #21078

@vmuzikar

Copy link
Copy Markdown
Contributor Author

Actually, removed that bouncycastle property as it's not used anywhere anymore. :)

Pepo48 added a commit to Pepo48/keycloak that referenced this pull request Jul 2, 2023
* reverted Quarkus upgrade as it is going to be handled separately in keycloak#21352

Signed-off-by: Peter Zaoral <pzaoral@redhat.com>
@Pepo48 Pepo48 mentioned this pull request Jul 2, 2023

@mabartos mabartos left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vmuzikar LGTM

@vmuzikar
vmuzikar requested a review from abstractj July 3, 2023 09:32
@pedroigor
pedroigor merged commit 8db6f81 into keycloak:main Jul 3, 2023
@pedroigor

Copy link
Copy Markdown
Contributor

@vmuzikar @abstractj Just noticed I should have waited for your review. Sorry.

@abstractj

Copy link
Copy Markdown
Contributor

@pedroigor nah, it's all good, thanks for merging Pedro.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade to Quarkus 3.2.0.Final

4 participants