Skip to content

Unnecessary Dependency byteman introduced via JGroups via Infinispan - #22434

Closed
ahus1 wants to merge 1 commit into
keycloak:mainfrom
ahus1:is-22433-remove-byteman-dependency
Closed

Unnecessary Dependency byteman introduced via JGroups via Infinispan#22434
ahus1 wants to merge 1 commit into
keycloak:mainfrom
ahus1:is-22433-remove-byteman-dependency

Conversation

@ahus1

@ahus1 ahus1 commented Aug 14, 2023

Copy link
Copy Markdown
Member

Closes #22433

@ahus1 ahus1 self-assigned this Aug 14, 2023
@ghost ghost added the flaky-test label Aug 14, 2023
ghost
ghost reviewed Aug 14, 2023
View reviewed changes

@ghost ghost left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@ghost

ghost commented Aug 14, 2023

Copy link
Copy Markdown

Unreported flaky test detected

If the below flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.webauthn.account.WebAuthnErrorTest#errorPageWithTimeout

Keycloak CI - WebAuthn IT (chrome)

java.lang.AssertionError: Expected OIDCLogin but was  (https://localhost:8543/auth/realms/test/protocol/openid-connect/auth?client_id=account-console&redirect_uri=https%3A%2F%2Flocalhost%3A8543%2Fauth%2Frealms%2Ftest%2Faccount%2F%23%2Fsecurity%2Fsigningin&state=1cd9c3dd-1c6f-4a25-b81c-0d81f328b1f4&response_mode=fragment&response_type=code&scope=openid&nonce=fc349375-6a8e-47e3-9e9a-a423ac9baf12&code_challenge=qHqgyxP5IWvL1P6QImWKUne291LeeMG6hNHNQtwS4oo&code_challenge_method=S256)
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.keycloak.testsuite.page.AbstractPage.assertCurrent(AbstractPage.java:110)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
...

Report flaky test

@ahus1

ahus1 commented Aug 15, 2023

Copy link
Copy Markdown
Member Author

Obsolete, will be handled by #22386

@ahus1 ahus1 closed this Aug 15, 2023
@ahus1
ahus1 deleted the is-22433-remove-byteman-dependency branch September 21, 2023 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot will automatically review once the pull request is marked ready for review
1 more reviewer
Reviewers whose approvals may not affect merge requirements

Assignees

@ahus1 ahus1

Labels

flaky-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Unnecessary Dependency byteman introduced via JGroups via Infinispan

1 participant

@ahus1