Skip to content

Fix IDELauncher after removing Vert.x Dev UI dependency - #22494

Merged
vmuzikar merged 1 commit into
keycloak:mainfrom
mabartos:ideLauncher-vertx-dev-ui
Aug 17, 2023
Merged

Fix IDELauncher after removing Vert.x Dev UI dependency#22494
vmuzikar merged 1 commit into
keycloak:mainfrom
mabartos:ideLauncher-vertx-dev-ui

Conversation

@mabartos

Copy link
Copy Markdown
Member

I was able to reproduce an issue with missing dependency during the IDELauncher start.

I've added the dependency to the server module, so it's possible to start Keycloak through the IDELauncher again.
The transitive JARs of the artifact are not included in the distribution.

@vmuzikar Could you please check it?

@mabartos
mabartos requested review from a team as code owners August 16, 2023 15:30
@mabartos
mabartos requested a review from vmuzikar August 16, 2023 15:30
@shawkins

Copy link
Copy Markdown
Contributor

Thanks @mabartos I'll include this in the backport as well.

@vmuzikar vmuzikar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mabartos Thanks, LGTM. As discussed offline, puting the hold label for now so we could double check if there isn't a way we could just disable the dev UI.

@vmuzikar vmuzikar added the status/hold PR should not be merged. On hold for later. label Aug 16, 2023
@vmuzikar vmuzikar removed the status/hold PR should not be merged. On hold for later. label Aug 17, 2023

@vmuzikar vmuzikar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed with @mabartos, there's no better solution than this and this module doesn't affect dist at all, so should be good enough for prod.

@ASzc jFYI

@vmuzikar
vmuzikar enabled auto-merge (squash) August 17, 2023 14:08
@vmuzikar
vmuzikar merged commit 60ac69d into keycloak:main Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants