Merged
Conversation
Signed-off-by: Michal Hajas <mhajas@redhat.com>
Contributor
Author
|
I checked also |
3 flaky tests on run #8589 ↗︎Details:
|
|||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Authentication test > should add a condition |
Output
Screenshots
|
|
realm_settings_events_test.spec.ts • 1 flaky test • chrome
| Test | Artifacts | |
|---|---|---|
| Realm settings events tab tests > Should remove event from event listener |
Output
Screenshots
|
|
realm_settings_general_tab_test.spec.ts • 1 flaky test • chrome
| Test | Artifacts | |
|---|---|---|
| Realm settings general tab tests > Test all general tab switches |
Output
Screenshots
|
|
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
stianst
approved these changes
Aug 23, 2023
Unreported flaky test detectedIf the below flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR. org.keycloak.testsuite.forms.BrowserFlowTest#testAlternativeNonInteractiveExecutorInSubflowKeycloak CI - Forms IT (firefox) org.keycloak.testsuite.model.ConcurrentHashMapStorageTest#testStorageSeparationKeycloak CI - Store Model Tests |
ghost
reviewed
Aug 23, 2023
ghost
left a comment
There was a problem hiding this comment.
Unreported flaky test detected, please review
stianst
pushed a commit
to stianst/keycloak
that referenced
this pull request
Sep 4, 2023
Signed-off-by: Michal Hajas <mhajas@redhat.com>
stianst
pushed a commit
that referenced
this pull request
Sep 4, 2023
Signed-off-by: Michal Hajas <mhajas@redhat.com>
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the current state, not all flaky tests are reported. The reason for that is that sometimes the failed attempt is reported as a failure and sometimes as an error. The current
upload-flaky-testis looking only for<flakyFailurestring in surefire-reports, however, we need to search also for<flakyError.More info here: https://maven.apache.org/surefire/maven-surefire-plugin/examples/rerun-failing-tests.html#output-flaky-re-run-information-in-test-report-xml