Skip to content

Fixed remaining a11y violations for account console #22673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
agagancarczyk merged 8 commits into from
Aug 28, 2023
Merged

Fixed remaining a11y violations for account console #22673

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
e7c9f87
fixed critical a11y violation on Application page
agagancarczyk Aug 23, 2023
1d85f35
fixed moderate a11y violation on Application page
agagancarczyk Aug 23, 2023
bcfd540
fixed serious a11y violation on Signin page
agagancarczyk Aug 23, 2023
2aaccb7
Merge branch 'main' of https://github.com/keycloak/keycloak into issu…
agagancarczyk Aug 28, 2023
0c38ca9
fixed aria-label
agagancarczyk Aug 28, 2023
f2f8a9f
updated label
agagancarczyk Aug 28, 2023
70ae747
Merge branch 'main' of https://github.com/keycloak/keycloak into issu…
agagancarczyk Aug 28, 2023
afeeb0d
Add Dutch translation
jonkoops Aug 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion js/apps/account-ui/public/locales/en/translation.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"accountUpdatedMessage": "Your account has been updated.",
"add": "Add",
"application": "Application",
"applicationDetails": "Application details",
"applicationDetails": "Application details for {{clientId}}",
"applications": "Applications",
"applicationsIntroMessage": "View applications your account has access to",
"applicationType": "Application type",
Expand Down
2 changes: 1 addition & 1 deletion js/apps/account-ui/public/locales/nl/translation.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"accountUpdatedMessage": "Uw account is bijgewerkt.",
"add": "Toevoegen",
"application": "Applicatie",
"applicationDetails": "Applicatiegegevens",
"applicationDetails": "Applicatiegegevens voor {{clientId}}",
"applications": "Applicaties",
"applicationsIntroMessage": "Bekijk applicaties waartoe uw account toegang heeft",
"applicationType": "Applicatietype",
Expand Down
210 changes: 103 additions & 107 deletions js/apps/account-ui/src/account-security/SigningIn.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,116 +112,112 @@ const SigningIn = () => {

return (
<Page title={t("signingIn")} description={t("signingInDescription")}>
<DataList aria-label="user credential" className="pf-u-mb-xl">
{credentials.map((container) => (
<PageSection
key={container.category}
variant="light"
className="pf-u-px-0"
>
<Title headingLevel="h2" size="xl">
{t(container.category as TFuncKey)}
</Title>
<Split className="pf-u-mt-lg pf-u-mb-lg">
<SplitItem>
<Title headingLevel="h3" size="md" className="pf-u-mb-md">
<span className="cred-title pf-u-display-block">
{t(container.displayName as TFuncKey)}
</span>
</Title>
{t(container.helptext as TFuncKey)}
{credentials.map((container) => (
<PageSection
key={container.category}
variant="light"
className="pf-u-px-0"
>
<Title headingLevel="h2" size="xl">
{t(container.category as TFuncKey)}
</Title>
<Split className="pf-u-mt-lg pf-u-mb-lg">
<SplitItem>
<Title headingLevel="h3" size="md" className="pf-u-mb-md">
<span className="cred-title pf-u-display-block">
{t(container.displayName as TFuncKey)}
</span>
</Title>
{t(container.helptext as TFuncKey)}
</SplitItem>
{container.createAction && (
<SplitItem isFilled>
<div className="pf-u-float-right">
<MobileLink
onClick={() =>
login({
action: container.createAction,
})
}
title={t("setUpNew", [
t(container.displayName as TFuncKey),
])}
/>
</div>
</SplitItem>
{container.createAction && (
<SplitItem isFilled>
<div className="pf-u-float-right">
<MobileLink
onClick={() =>
login({
action: container.createAction,
})
}
title={t("setUpNew", [
t(container.displayName as TFuncKey),
])}
/>
</div>
</SplitItem>
)}
</Split>
)}
</Split>

<DataList aria-label="credential list" className="pf-u-mb-xl">
{container.userCredentialMetadatas.length === 0 && (
<EmptyRow
message={t("notSetUp", [
t(container.displayName as TFuncKey),
])}
/>
)}
<DataList aria-label="credential list" className="pf-u-mb-xl">
{container.userCredentialMetadatas.length === 0 && (
<EmptyRow
message={t("notSetUp", [t(container.displayName as TFuncKey)])}
/>
)}

{container.userCredentialMetadatas.map((meta) => (
<DataListItem key={meta.credential.id}>
<DataListItemRow>
<DataListItemCells
className="pf-u-py-0"
dataListCells={[
...credentialRowCells(meta),
<DataListAction
key="action"
id={`action-${meta.credential.id}`}
aria-label={t("updateCredAriaLabel")}
aria-labelledby={`cred-${meta.credential.id}`}
>
{container.removeable ? (
<ContinueCancelModal
buttonTitle={t("delete")}
modalTitle={t("removeCred", [
label(meta.credential),
])}
continueLabel={t("confirm")}
cancelLabel={t("cancel")}
buttonVariant="danger"
onContinue={async () => {
try {
await deleteCredentials(meta.credential);
addAlert(
t("successRemovedMessage", {
userLabel: label(meta.credential),
}),
);
refresh();
} catch (error) {
addError(
t("errorRemovedMessage", {
userLabel: label(meta.credential),
error,
}).toString(),
);
}
}}
>
{t("stopUsingCred", [label(meta.credential)])}
</ContinueCancelModal>
) : (
<Button
variant="secondary"
onClick={() => {
if (container.updateAction)
login({ action: container.updateAction });
}}
>
{t("update")}
</Button>
)}
</DataListAction>,
]}
/>
</DataListItemRow>
</DataListItem>
))}
</DataList>
</PageSection>
))}
</DataList>
{container.userCredentialMetadatas.map((meta) => (
<DataListItem key={meta.credential.id}>
<DataListItemRow>
<DataListItemCells
className="pf-u-py-0"
dataListCells={[
...credentialRowCells(meta),
<DataListAction
key="action"
id={`action-${meta.credential.id}`}
aria-label={t("updateCredAriaLabel")}
aria-labelledby={`cred-${meta.credential.id}`}
>
{container.removeable ? (
<ContinueCancelModal
buttonTitle={t("delete")}
modalTitle={t("removeCred", [
label(meta.credential),
])}
continueLabel={t("confirm")}
cancelLabel={t("cancel")}
buttonVariant="danger"
onContinue={async () => {
try {
await deleteCredentials(meta.credential);
addAlert(
t("successRemovedMessage", {
userLabel: label(meta.credential),
}),
);
refresh();
} catch (error) {
addError(
t("errorRemovedMessage", {
userLabel: label(meta.credential),
error,
}).toString(),
);
}
}}
>
{t("stopUsingCred", [label(meta.credential)])}
</ContinueCancelModal>
) : (
<Button
variant="secondary"
onClick={() => {
if (container.updateAction)
login({ action: container.updateAction });
}}
>
{t("update")}
</Button>
)}
</DataListAction>,
]}
/>
</DataListItemRow>
</DataListItem>
))}
</DataList>
</PageSection>
))}
</Page>
);
};
Expand Down
8 changes: 6 additions & 2 deletions js/apps/account-ui/src/applications/Applications.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ const Applications = () => {
<span style={{ visibility: "hidden", height: 55 }}>
<DataListToggle
id="applications-list-header-invisible-toggle"
aria-controls="hidden"
aria-controls="applications-list-content"
/>
</span>
<DataListItemCells
Expand Down Expand Up @@ -122,6 +122,7 @@ const Applications = () => {
onClick={() => toggleOpen(application.clientId)}
isExpanded={application.open}
id={`toggle-${application.clientId}`}
aria-controls={`content-${application.clientId}`}
/>
<DataListItemCells
className="pf-u-align-items-center"
Expand Down Expand Up @@ -154,8 +155,11 @@ const Applications = () => {
</DataListItemRow>

<DataListContent
id={`content-${application.clientId}`}
className="pf-u-pl-4xl"
aria-label={t("applicationDetails")}
aria-label={t("applicationDetails", {
clientId: application.clientId,
Comment thread
jonkoops marked this conversation as resolved.
})}
isHidden={!application.open}
>
<DescriptionList>
Expand Down