Skip to content

Provide support for determining community/product guides#22763

Merged
ahus1 merged 1 commit intokeycloak:mainfrom
mabartos:KC-22762
Aug 29, 2023
Merged

Provide support for determining community/product guides#22763
ahus1 merged 1 commit intokeycloak:mainfrom
mabartos:KC-22762

Conversation

@mabartos
Copy link
Contributor

@mabartos mabartos commented Aug 28, 2023

Closes #22762

Necessary for #22615

More info in the associated issue.

@mabartos mabartos requested a review from a team as a code owner August 28, 2023 14:35
</#macro>

<#macro ifCommunity>
ifeval::[{project_product} != true]
Copy link
Contributor Author

@mabartos mabartos Aug 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the community guides, it's always evaluated to true, and for the product always to false. It's a universal solution for community and product guides.

@mabartos mabartos requested review from ahus1, mhajas and vmuzikar August 28, 2023 14:37
@vmuzikar
Copy link
Contributor

This will have to be backported to 22 to have aligned functionality. This will be required for the backport of #22615

@mabartos mabartos added the status/hold PR should not be merged. On hold for later. label Aug 29, 2023
@mabartos
Copy link
Contributor Author

Just hold for now in order to investigate a little bit more.

#22763 (comment)

@mabartos mabartos removed the status/hold PR should not be merged. On hold for later. label Aug 29, 2023
Copy link
Member

@ahus1 ahus1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this as it mimics the behavior already introduced in the KC22 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Provide support for determining community/product guides

3 participants

Comments