Provide support for determining community/product guides - #22763
Merged
Conversation
mabartos
commented
Aug 28, 2023
| </#macro> | ||
|
|
||
| <#macro ifCommunity> | ||
| ifeval::[{project_product} != true] |
Member
Author
There was a problem hiding this comment.
For the community guides, it's always evaluated to true, and for the product always to false. It's a universal solution for community and product guides.
vmuzikar
reviewed
Aug 28, 2023
vmuzikar
approved these changes
Aug 29, 2023
Contributor
|
This will have to be backported to 22 to have aligned functionality. This will be required for the backport of #22615 |
Member
Author
|
Just hold for now in order to investigate a little bit more. |
ahus1
approved these changes
Aug 29, 2023
ahus1
left a comment
Member
There was a problem hiding this comment.
Approving this as it mimics the behavior already introduced in the KC22 branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #22762
Necessary for #22615
More info in the associated issue.