Skip to content

Backports #22670 - #22766

Merged
jonkoops merged 5 commits into
keycloak:release/22.0from
agagancarczyk:backport-22670
Aug 29, 2023
Merged

Backports #22670#22766
jonkoops merged 5 commits into
keycloak:release/22.0from
agagancarczyk:backport-22670

Conversation

@agagancarczyk

Copy link
Copy Markdown
Contributor

Backports #22670

Comment thread js/apps/account-ui/public/locales/nl/translation.json Outdated
@agagancarczyk
agagancarczyk requested a review from jonkoops August 29, 2023 09:02

@jonkoops jonkoops left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still a couple of changes that were not in the original PR.

Comment thread js/apps/account-ui/src/account-security/SigningIn.tsx Outdated
Comment thread js/apps/account-ui/src/account-security/SigningIn.tsx
Comment thread js/apps/account-ui/src/account-security/SigningIn.tsx Outdated
@agagancarczyk
agagancarczyk requested a review from jonkoops August 29, 2023 10:02
Comment thread js/apps/account-ui/src/account-security/SigningIn.tsx Outdated
Comment thread js/apps/account-ui/src/account-security/SigningIn.tsx

@jonkoops jonkoops left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jonkoops
jonkoops enabled auto-merge (squash) August 29, 2023 10:31
@cypress

cypress Bot commented Aug 29, 2023

Copy link
Copy Markdown

1 flaky test on run #8699 ↗︎

0 527 48 0 Flakiness 1

Details:

Merge 2fe8e79 into 61ca260...
Project: Keycloak Admin UI Commit: 337ec51cc4 ℹ️
Status: Passed Duration: 33:58 💡
Started: Aug 29, 2023 10:59 AM Ended: Aug 29, 2023 12:33 PM
Flakiness  cypress/e2e/authentication_test.spec.ts • 1 flaky test • chrome

View Output Video

Test Artifacts
Authentication test > should add a condition Output Screenshots

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@jonkoops
jonkoops merged commit e39b9c3 into keycloak:release/22.0 Aug 29, 2023
This was referenced Sep 4, 2023
@stianst stianst mentioned this pull request Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants