Skip to content

Remove log-level property for ClassTransformingBuildStep in Quarkus - #22794

Merged
vmuzikar merged 1 commit into
keycloak:mainfrom
mabartos:KC-22793
Aug 30, 2023
Merged

Remove log-level property for ClassTransformingBuildStep in Quarkus#22794
vmuzikar merged 1 commit into
keycloak:mainfrom
mabartos:KC-22793

Conversation

@mabartos

@mabartos mabartos commented Aug 29, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Closes #22793

@mabartos
mabartos requested review from a team as code owners August 29, 2023 13:07
@mabartos mabartos added status/hold PR should not be merged. On hold for later. and removed team/cloud-native labels Aug 29, 2023
@ghost ghost added the flaky-test label Aug 29, 2023
@ghost ghost mentioned this pull request Aug 29, 2023
Closed
ghost
ghost reviewed Aug 29, 2023
View reviewed changes

@ghost ghost left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@ghost

ghost commented Aug 29, 2023

Copy link
Copy Markdown

Unreported flaky test detected

If the below flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.ui.account2.SessionTest#welcomeScreenAsyncLogoutTest

Keycloak CI - Account Console IT (firefox)

org.awaitility.core.ConditionTimeoutException: Assertion condition defined as a org.keycloak.testsuite.util.URLAssert URL expected to begin with: https://localhost:8543/auth/realms/test/protocol/openid-connect/auth ; actual URL: https://localhost:8543/auth/realms/test/account/#/personal-info within 10 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:31)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:985)
...

Report flaky test

@mabartos mabartos removed the status/hold PR should not be merged. On hold for later. label Aug 30, 2023
@mabartos

mabartos commented Aug 30, 2023

Copy link
Copy Markdown
Member Author

As Quarkus 3.2.5 is already present in the codebase, we can continue with this.

I've tried the approach and these warnings are not shown anymore.

@vmuzikar
vmuzikar merged commit 3c00286 into keycloak:main Aug 30, 2023
@mabartos mabartos mentioned this pull request Aug 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vmuzikar vmuzikar vmuzikar approved these changes
@shawkins shawkins Awaiting requested review from shawkins
@Pepo48 Pepo48 Awaiting requested review from Pepo48
+1 more reviewer
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

flaky-test team/cloud-native

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove log-level property for ClassTransformingBuildStep in Quarkus

2 participants

@mabartos @vmuzikar