Removes the bundle generator from the runtime - #22820
Merged
Merged
Conversation
Contributor
Author
At the provided scope, we'll fail to build with the error: So if a filtered optional dependency does not work, then we'll need some additional upstream changes. |
Contributor
Can't we scope it to |
Contributor
Author
|
No, that's what the first part of the comment is saying. |
Contributor
|
LGTM, |
Contributor
Sorry, read it wrong. :) Optional seems to work, let's wait for the tests and we're good to go. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #22573