Skip to content

Error message when JDBC driver is missing is not helpful - #22934

Merged
vmuzikar merged 1 commit into
keycloak:release/22.0from
mabartos:removeLogBackport
Sep 4, 2023
Merged

Error message when JDBC driver is missing is not helpful#22934
vmuzikar merged 1 commit into
keycloak:release/22.0from
mabartos:removeLogBackport

Conversation

@mabartos

@mabartos mabartos commented Sep 4, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Closes #22795

Backport of #22833

@vmuzikar Could you check it, please?

@mabartos
mabartos marked this pull request as ready for review September 4, 2023 12:32
@mabartos
mabartos requested review from a team as code owners September 4, 2023 12:32
@ghost ghost added team/cloud-native labels Sep 4, 2023
@vmuzikar vmuzikar linked an issue Sep 4, 2023 that may be closed by this pull request
Error message when JDBC driver is missing is not helpful #22795
Closed
@vmuzikar
vmuzikar enabled auto-merge (squash) September 4, 2023 12:39
vmuzikar
vmuzikar reviewed Sep 4, 2023
View reviewed changes

@vmuzikar vmuzikar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests seem to have failed because in 22 we include the Oracle driver by default.

auto-merge was automatically disabled September 4, 2023 13:35

Head branch was pushed to by a user without write access

@vmuzikar
vmuzikar enabled auto-merge (squash) September 4, 2023 13:39
@vmuzikar
vmuzikar disabled auto-merge September 4, 2023 14:09
@vmuzikar
vmuzikar enabled auto-merge (squash) September 4, 2023 14:23
@ghost ghost added the flaky-test label Sep 4, 2023
@ghost ghost mentioned this pull request Sep 4, 2023
Closed
ghost
ghost reviewed Sep 4, 2023
View reviewed changes

@ghost ghost left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@ghost

ghost commented Sep 4, 2023

Copy link
Copy Markdown

Unreported flaky test detected

If the below flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.forms.RegisterTest#testEmailAsUsernameWhenEditUserNameDisabled

Keycloak CI - Forms IT (chrome)

java.lang.IllegalArgumentException: No enum constant org.keycloak.testsuite.pages.AppPage.RequestType.
	at java.base/java.lang.Enum.valueOf(Enum.java:273)
	at org.keycloak.testsuite.pages.AppPage$RequestType.valueOf(AppPage.java:56)
	at org.keycloak.testsuite.pages.AppPage.getRequestType(AppPage.java:49)
	at jdk.internal.reflect.GeneratedMethodAccessor551.invoke(Unknown Source)
...

Report flaky test

@vmuzikar
vmuzikar merged commit d6a0b90 into keycloak:release/22.0 Sep 4, 2023
@stianst stianst mentioned this pull request Sep 6, 2023
Closed
@mabartos mabartos mentioned this pull request Sep 6, 2023
Merged
@stianst stianst mentioned this pull request Sep 11, 2023
Closed
@stianst stianst mentioned this pull request Nov 14, 2023
Closed
@stianst stianst mentioned this pull request May 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vmuzikar vmuzikar vmuzikar approved these changes
+1 more reviewer
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

flaky-test team/cloud-native

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Error message when JDBC driver is missing is not helpful

2 participants

@mabartos @vmuzikar