Skip to content

Upgrade to Infinispan 14.0.16 - #22945

Merged
mhajas merged 1 commit into
keycloak:mainfrom
ahus1:is-22932-upgrade-infinispan-14.0.16
Sep 5, 2023
Merged

Upgrade to Infinispan 14.0.16#22945
mhajas merged 1 commit into
keycloak:mainfrom
ahus1:is-22932-upgrade-infinispan-14.0.16

Conversation

@ahus1

@ahus1 ahus1 commented Sep 4, 2023

Copy link
Copy Markdown
Member

Closes #22932

@ahus1 ahus1 self-assigned this Sep 4, 2023
@ahus1

ahus1 commented Sep 4, 2023

Copy link
Copy Markdown
Member Author

@mhajas - I'm still waiting for the builds to complete, and some failed to due some GHA outage, and I might need to rerun them.

Maybe you want to review them already, assuming those tests succeed?

@ahus1
ahus1 requested a review from mhajas September 4, 2023 14:45
@ghost ghost added the flaky-test label Sep 4, 2023
@ghost

ghost commented Sep 4, 2023

Copy link
Copy Markdown

Unreported flaky test detected

If the below flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.forms.RegisterTest#testEmailAsUsernameWhenEditUserNameDisabled

Keycloak CI - Forms IT (chrome)

java.lang.IllegalArgumentException: No enum constant org.keycloak.testsuite.pages.AppPage.RequestType.
	at java.base/java.lang.Enum.valueOf(Enum.java:273)
	at org.keycloak.testsuite.pages.AppPage$RequestType.valueOf(AppPage.java:56)
	at org.keycloak.testsuite.pages.AppPage.getRequestType(AppPage.java:49)
	at jdk.internal.reflect.GeneratedMethodAccessor553.invoke(Unknown Source)
...

Report flaky test

ghost
ghost reviewed Sep 4, 2023
View reviewed changes

@ghost ghost left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

This was referenced Sep 4, 2023
Closed
Closed
Closed
ghost
ghost reviewed Sep 4, 2023
View reviewed changes

@ghost ghost left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@ghost

ghost commented Sep 4, 2023

Copy link
Copy Markdown

Unreported flaky test detected

If the below flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.forms.RegisterTest#testEmailAsUsernameWhenEditUserNameDisabled

Keycloak CI - Forms IT (chrome)

java.lang.IllegalArgumentException: No enum constant org.keycloak.testsuite.pages.AppPage.RequestType.
	at java.base/java.lang.Enum.valueOf(Enum.java:273)
	at org.keycloak.testsuite.pages.AppPage$RequestType.valueOf(AppPage.java:56)
	at org.keycloak.testsuite.pages.AppPage.getRequestType(AppPage.java:49)
	at jdk.internal.reflect.GeneratedMethodAccessor553.invoke(Unknown Source)
...

Report flaky test

@ahus1
ahus1 marked this pull request as ready for review September 4, 2023 20:03
@ahus1
ahus1 requested a review from a team as a code owner September 4, 2023 20:03
@mhajas mhajas mentioned this pull request Sep 5, 2023
Closed
@mhajas mhajas removed the flaky-test label Sep 5, 2023
@mhajas mhajas self-assigned this Sep 5, 2023
mhajas
mhajas approved these changes Sep 5, 2023
View reviewed changes

@mhajas mhajas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ahus1, LGTM

@mhajas
mhajas merged commit 71fa957 into keycloak:main Sep 5, 2023
@ahus1 ahus1 mentioned this pull request Sep 5, 2023
Merged
@ahus1
ahus1 deleted the is-22932-upgrade-infinispan-14.0.16 branch September 21, 2023 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@mhajas mhajas mhajas approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@ahus1 ahus1

@mhajas mhajas

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Upgrade to Infinispan 14.0.16.Final once released

2 participants

@ahus1 @mhajas