Skip to content

Attributes without a value set are not rendered in the account console - #22968

Merged
jonkoops merged 1 commit into
keycloak:mainfrom
pedroigor:userprofile-ui
Sep 8, 2023
Merged

Attributes without a value set are not rendered in the account console #22968
jonkoops merged 1 commit into
keycloak:mainfrom
pedroigor:userprofile-ui

Conversation

@pedroigor

@pedroigor pedroigor commented Sep 5, 2023

Copy link
Copy Markdown
Contributor

Closes #22961

@pedroigor
pedroigor requested a review from a team as a code owner September 5, 2023 01:01
@ghost ghost added the team/ui label Sep 5, 2023
@pedroigor
pedroigor requested a review from edewit September 5, 2023 01:08
@ghost ghost added the flaky-test label Sep 5, 2023
This was referenced Sep 5, 2023
Closed
Closed
ghost
ghost reviewed Sep 5, 2023
View reviewed changes

@ghost ghost left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@ghost

ghost commented Sep 5, 2023

Copy link
Copy Markdown

Unreported flaky test detected

If the below flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.ui.account2.SessionTest#welcomeScreenAsyncLogoutTest

Keycloak CI - Account Console IT (firefox)

org.awaitility.core.ConditionTimeoutException: Assertion condition defined as a org.keycloak.testsuite.util.URLAssert URL expected to begin with: https://localhost:8543/auth/realms/test/protocol/openid-connect/auth ; actual URL: https://localhost:8543/auth/realms/test/account/#/personal-info within 10 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:31)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:985)
...

Report flaky test

@pedroigor pedroigor changed the title Do not store empty attributes when updating user profile Attributes without a value set are not rendered in the account console Sep 5, 2023
@pedroigor
pedroigor requested a review from mposolda September 5, 2023 19:40
mposolda
mposolda approved these changes Sep 8, 2023
View reviewed changes

@mposolda mposolda left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pedroigor Looks good. Will be good to have review from someone from UI team as well IMO.

@jonkoops

jonkoops commented Sep 8, 2023

Copy link
Copy Markdown
Contributor

Note that this only updated the V2 version of the Account Console. I am not aware of whether this bug is also present in new version.

@jonkoops
jonkoops merged commit 4d71138 into keycloak:main Sep 8, 2023
pedroigor added a commit to pedroigor/keycloak that referenced this pull request Sep 8, 2023
@pedroigor
Attributes without a value set are not rendered in the account console (
9e5d75f 
keycloak#22968)

Closes keycloak#22961
@pedroigor pedroigor mentioned this pull request Sep 8, 2023
Merged
stianst pushed a commit that referenced this pull request Sep 11, 2023
@pedroigor @stianst
Attributes without a value set are not rendered in the account console (
38522e4 
#22968)

Closes #22961
@stianst stianst mentioned this pull request Sep 11, 2023
Closed
@stianst stianst mentioned this pull request Nov 14, 2023
Closed
@stianst stianst mentioned this pull request May 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mposolda mposolda mposolda approved these changes
@edewit edewit Awaiting requested review from edewit
+2 more reviewers
@jonkoops jonkoops jonkoops approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

flaky-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Attributes without a value set are not rendered in the account console

3 participants

@pedroigor @jonkoops @mposolda