Skip to content

Refactor conditional in GH workflows #22020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stianst merged 1 commit into from
Jul 28, 2023
Merged

Refactor conditional in GH workflows #22020

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 0 additions & 34 deletions .github/actions/checks-job-pass/action.yml
View file
Open in desktop

This file was deleted.

16 changes: 0 additions & 16 deletions .github/actions/checks-success/action.yml
View file
Open in desktop

This file was deleted.

27 changes: 27 additions & 0 deletions .github/actions/status-check/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
name: Check required jobs
description: Check if all required jobs where successful or skipped

inputs:
jobs:
description: Jobs (value must be toJSON(needs))
required: true

runs:
using: "composite"
Comment thread
stianst marked this conversation as resolved.
steps:
- id: check-jobs
name: Check jobs
shell: bash
run: |
JOBS='${{ inputs.jobs }}'

echo "Job status:"
echo $JOBS | jq -r 'to_entries[] | " - \(.key): \(.value.result)"'

for i in $(echo $JOBS | jq -r 'to_entries[] | .value.result'); do
if [ "$i" != "success" ] && [ "$i" != "skipped" ]; then
echo ""
echo "Status check not okay!"
exit 1
fi
done
29 changes: 5 additions & 24 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -572,8 +572,9 @@ jobs:
with:
job-name: Migration Tests

check-set-status:
name: Set check conclusion
check:
name: Status Check - Keycloak CI
if: always()
needs:
- unit-tests
- base-integration-tests
Expand All @@ -591,28 +592,8 @@ jobs:
- sssd-unit-tests
- migration-tests
runs-on: ubuntu-latest
outputs:
conclusion: ${{ steps.check.outputs.conclusion }}

steps:
- uses: actions/checkout@v3

- id: check
uses: ./.github/actions/checks-success

check:
name: Status Check - Keycloak CI
if: always()
needs:
- conditional
- check-set-status
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v3

- name: Check status
uses: ./.github/actions/checks-job-pass
- uses: ./.github/actions/status-check
with:
required: ${{ needs.conditional.outputs.ci }}
conclusion: ${{ needs.check-set-status.outputs.conclusion }}
jobs: ${{ toJSON(needs) }}
24 changes: 5 additions & 19 deletions .github/workflows/codeql-analysis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,9 +60,6 @@ jobs:
env:
CODEQL_ACTION_EXTRA_OPTIONS: '{"database":{"interpret-results":["--max-paths",0]}}'

- id: check
uses: ./.github/actions/checks-success

themes:
name: CodeQL Themes
needs: conditional
Expand All @@ -89,26 +86,15 @@ jobs:
env:
CODEQL_ACTION_EXTRA_OPTIONS: '{"database":{"interpret-results":["--max-paths",0]}}'

- id: check
uses: ./.github/actions/checks-success

check:
name: Status Check - CodeQL
if: always()
needs: [conditional, java, themes]
needs:
- java
- themes
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v3

- name: CodeQL Java
uses: ./.github/actions/checks-job-pass
with:
required: ${{ needs.conditional.outputs.java }}
conclusion: ${{ needs.java.outputs.conclusion }}

- name: CodeQL Themes
uses: ./.github/actions/checks-job-pass
- uses: ./.github/actions/status-check
with:
required: ${{ needs.conditional.outputs.themes }}
conclusion: ${{ needs.themes.outputs.conclusion }}
jobs: ${{ toJSON(needs) }}
25 changes: 3 additions & 22 deletions .github/workflows/documentation.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,33 +98,14 @@ jobs:
run: |
./mvnw test -Dtest=ExternalLinksTest -am -pl docs/documentation/tests,docs/documentation/dist -nsu -B -e -Pdocumentation

check-set-status:
name: Set check conclusion
needs:
- build
runs-on: ubuntu-latest
outputs:
conclusion: ${{ steps.check.outputs.conclusion }}

steps:
- uses: actions/checkout@v3

- id: check
uses: ./.github/actions/checks-success

check:
name: Status Check - Keycloak Documentation
if: always()
needs:
- conditional
- check-set-status
- build
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v3

- name: Check status
uses: ./.github/actions/checks-job-pass
- uses: ./.github/actions/status-check
with:
required: ${{ needs.conditional.outputs.documentation == 'true' }}
conclusion: ${{ needs.check-set-status.outputs.conclusion }}
jobs: ${{ toJSON(needs) }}
25 changes: 3 additions & 22 deletions .github/workflows/guides.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,33 +45,14 @@ jobs:
- name: Build Keycloak
uses: ./.github/actions/build-keycloak

check-set-status:
name: Set check conclusion
needs:
- build
runs-on: ubuntu-latest
outputs:
conclusion: ${{ steps.check.outputs.conclusion }}

steps:
- uses: actions/checkout@v3

- id: check
uses: ./.github/actions/checks-success

check:
name: Status Check - Keycloak Guides
if: always()
needs:
- conditional
- check-set-status
- build
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v3

- name: Check status
uses: ./.github/actions/checks-job-pass
- uses: ./.github/actions/status-check
with:
required: ${{ needs.conditional.outputs.guides == 'true' && needs.conditional.outputs.ci != 'true' }}
conclusion: ${{ needs.check-set-status.outputs.conclusion }}
jobs: ${{ toJSON(needs) }}
27 changes: 5 additions & 22 deletions .github/workflows/js-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,8 +265,9 @@ jobs:
name: server-log-${{ matrix.container }}-${{ matrix.browser }}
path: ~/server.log

check-set-status:
name: Set check conclusion
check:
name: Status Check - Keycloak JavaScript CI
if: always()
needs:
- admin-client
- keycloak-js
Expand All @@ -276,26 +277,8 @@ jobs:
- admin-ui
- admin-ui-e2e
runs-on: ubuntu-latest
outputs:
conclusion: ${{ steps.check.outputs.conclusion }}
steps:
- uses: actions/checkout@v3

- id: check
uses: ./.github/actions/checks-success

check:
name: Status Check - Keycloak JavaScript CI
if: always()
needs:
- conditional
- check-set-status
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3

- name: Check status
uses: ./.github/actions/checks-job-pass
- uses: ./.github/actions/status-check
with:
required: ${{ needs.conditional.outputs.js-ci }}
conclusion: ${{ needs.check-set-status.outputs.conclusion }}
jobs: ${{ toJSON(needs) }}
29 changes: 5 additions & 24 deletions .github/workflows/operator-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,35 +199,16 @@ jobs:
# Wait for the CRs to be ready
./scripts/check-examples-installed.sh

check-set-status:
name: Set check conclusion
needs:
- test-local
- test-remote
- test-olm
runs-on: ubuntu-latest
outputs:
conclusion: ${{ steps.check.outputs.conclusion }}

steps:
- uses: actions/checkout@v3

- id: check
uses: ./.github/actions/checks-success

check:
name: Status Check - Keycloak Operator CI
if: always()
needs:
- conditional
- check-set-status
- test-local
- test-remote
- test-olm
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v3

- name: Check status
uses: ./.github/actions/checks-job-pass
- uses: ./.github/actions/status-check
with:
required: ${{ needs.conditional.outputs.operator }}
conclusion: ${{ needs.check-set-status.outputs.conclusion }}
jobs: ${{ toJSON(needs) }}