Skip to content

Execute CI when some changes were made in scripts dir - #22065

Merged
stianst merged 1 commit into
keycloak:mainfrom
mabartos:KC-22064-scripts-dir-ci
Jul 28, 2023
Merged

Execute CI when some changes were made in scripts dir#22065
stianst merged 1 commit into
keycloak:mainfrom
mabartos:KC-22064-scripts-dir-ci

Conversation

@mabartos

Copy link
Copy Markdown
Member

Fixes #22064

@stianst Could you please check it? Thanks

@mabartos
mabartos requested a review from a team as a code owner July 28, 2023 09:39
@mabartos
mabartos requested a review from stianst July 28, 2023 09:39
jonkoops
jonkoops previously approved these changes Jul 28, 2023
@mabartos

Copy link
Copy Markdown
Member Author

@jonkoops Thanks for the review. Resolved conflict with recent changes in the conditions.

@mabartos
mabartos requested a review from jonkoops July 28, 2023 10:23
@cypress

cypress Bot commented Jul 28, 2023

Copy link
Copy Markdown

2 flaky tests on run #8292 ↗︎

0 527 48 0 Flakiness 2

Details:

Merge 779ce31 into 0decccc...
Project: Keycloak Admin UI Commit: 302a07fcb8 ℹ️
Status: Passed Duration: 17:17 💡
Started: Jul 28, 2023 10:40 AM Ended: Jul 28, 2023 10:57 AM
Flakiness  authentication_test.spec.ts • 1 flaky test • chrome

View Output Video

Test Artifacts
Authentication test > should add a condition Output Screenshots
Flakiness  realm_settings_general_tab_test.spec.ts • 1 flaky test • chrome

View Output Video

Test Artifacts
Realm settings general tab tests > Test all general tab switches Output Screenshots

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@stianst
stianst enabled auto-merge (squash) July 28, 2023 10:57
@ghost ghost added the flaky-test label Jul 28, 2023

@ghost ghost left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@ghost

ghost commented Jul 28, 2023

Copy link
Copy Markdown

Unreported flaky test detected

If the below flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.model.session.OfflineSessionPersistenceTest#testPersistenceClientSessionsMultipleNodes

Keycloak CI - Store Model Tests

java.lang.AssertionError: 
threads didn't terminate in time: [main (TIMED_WAITING): locked on java.util.concurrent.FutureTask@2c0617ea waiting for 86489 ms blocked for 0 ms
	at java.base@17.0.7/jdk.internal.misc.Unsafe.park(Native Method)
	at java.base@17.0.7/java.util.concurrent.locks.LockSupport.parkNanos(LockSupport.java:252)
	at java.base@17.0.7/java.util.concurrent.FutureTask.awaitDone(FutureTask.java:444)
...

Report flaky test

@mabartos

Copy link
Copy Markdown
Member Author

@stianst @jonkoops The WebAuthn tests failures are not related to this PR. Could you rerun them, or just merge it as they're gonna be ignored anyway?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Execute CI when some changes were made in scripts dir

3 participants