Skip to content

Prevent exception in the log - #22201

Merged
mhajas merged 1 commit into
keycloak:mainfrom
ahus1:is-22200-prevent-exception-external-link-check-and-speedup
Sep 19, 2023
Merged

Prevent exception in the log#22201
mhajas merged 1 commit into
keycloak:mainfrom
ahus1:is-22200-prevent-exception-external-link-check-and-speedup

Conversation

@ahus1

@ahus1 ahus1 commented Aug 2, 2023

Copy link
Copy Markdown
Member

Also speed up the external link check by avoiding checking each bug submission link in the rendered docs which only differs by its parameter.

The external link check no completes in 2 minutes instead of 9 minutes on GitHub actions.

Closes #22200

Also speed up the external link check by avoiding checking each bug submission link in the rendered docs which only differs by its parameter.

Closes keycloak#22200
@ahus1 ahus1 self-assigned this Aug 2, 2023
@ahus1
ahus1 marked this pull request as ready for review August 3, 2023 08:36
@ahus1
ahus1 requested a review from a team as a code owner August 3, 2023 08:36
@ahus1

ahus1 commented Aug 3, 2023

Copy link
Copy Markdown
Member Author

@miquelsi - as you've reviewed PR #22187, I wonder if you'd feel confident to review this PR as well.

It avoids an exception in the log and speeds up the build by a few minutes.

As #22187 hasn't been merged yet, it shows the error in the external links (as it should).

Thanks!

@ahus1
ahus1 requested review from mhajas and miquelsi and removed request for miquelsi August 3, 2023 08:42
@ahus1

ahus1 commented Aug 7, 2023

Copy link
Copy Markdown
Member Author

@mhajas - I wonder if you could have a review for this one when you have the time. Thanks!

@mhajas mhajas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR @ahus1, I added one comment.

Comment thread .github/workflows/documentation.yml
@ahus1
ahus1 requested a review from mhajas September 6, 2023 14:33

@mhajas mhajas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ahus1

Comment thread .github/workflows/documentation.yml
@mhajas
mhajas merged commit 41fd12d into keycloak:main Sep 19, 2023
ahus1 added a commit to ahus1/keycloak that referenced this pull request Sep 21, 2023
Also speed up the external link check by avoiding checking each bug submission link in the rendered docs which only differs by its parameter.

Closes keycloak#22200

(cherry picked from commit 41fd12d)
@ahus1
ahus1 deleted the is-22200-prevent-exception-external-link-check-and-speedup branch September 21, 2023 17:05
ahus1 added a commit that referenced this pull request Oct 6, 2023
Also speed up the external link check by avoiding checking each bug submission link in the rendered docs which only differs by its parameter.

Closes #22200

(cherry picked from commit 41fd12d)
@stianst stianst mentioned this pull request Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

External Link check for documentation logs warning and exception: WARN FilenoUtil: Native subprocess control requires open access

2 participants