Changes to the time offset should be visible in all threads instantly - #22254
Merged
mhajas merged 1 commit intoAug 7, 2023
Merged
Conversation
This needs to be volatile as it is changed during tests at runtime and there is no other locking in place. Closes keycloak#22243
ahus1
force-pushed
the
is-22243-ensure-all-threads-see-time-offset
branch
from
August 4, 2023 14:02
8746f49 to
9e7b243
Compare
ahus1
marked this pull request as ready for review
August 4, 2023 16:37
Member
Author
|
When debugging this strange case where the session is sometimes expired correctly, and sometimes not, I stumbled across this non-volatile int. My search didn't reveal any other issues. It might fix the bug (which I was never able to reproduce locally). If it doesn't, we'll re-open the unstable test issue and continue the search. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This needs to be volatile as it is changed during tests at runtime and there is no other locking in place.
Closes #22243