Skip to content

Attach js-adapter to maven uploads and rewrite version to semver compatible if needed (#23512)#23555

Merged
stianst merged 1 commit intokeycloak:release/22.0from
stianst:backport-22.0-23512
Sep 27, 2023
Merged

Attach js-adapter to maven uploads and rewrite version to semver compatible if needed (#23512)#23555
stianst merged 1 commit intokeycloak:release/22.0from
stianst:backport-22.0-23512

Conversation

@stianst
Copy link
Contributor

@stianst stianst commented Sep 27, 2023

Closes #23312

@stianst stianst requested review from a team as code owners September 27, 2023 09:26
@ghost ghost added team/ui labels Sep 27, 2023
@stianst stianst requested a review from pskopek September 27, 2023 09:26
@cypress
Copy link

cypress bot commented Sep 27, 2023

Passing run #9125 ↗︎

0 527 48 0 Flakiness 0

Details:

Merge fa0d4b0 into 1e4f284...
Project: Keycloak Admin UI Commit: ac7a0c60f5 ℹ️
Status: Passed Duration: 15:48 💡
Started: Sep 27, 2023 9:44 AM Ended: Sep 27, 2023 10:00 AM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@ghost ghost added the flaky-test label Sep 27, 2023
@ghost ghost mentioned this pull request Sep 27, 2023
Closed
ghost
ghost reviewed Sep 27, 2023
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@ghost
Copy link

ghost commented Sep 27, 2023

Unreported flaky test detected

If the below flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.ui.account2.DeviceActivityTest#timesTests

Keycloak CI - Account Console IT (firefox)

org.awaitility.core.ConditionTimeoutException: Assertion condition defined as a org.keycloak.testsuite.util.URLAssert URL expected to begin with: https://localhost:8543/auth/realms/test/protocol/openid-connect/auth ; actual URL: https://localhost:8543/auth/realms/test/account/#/security/device-activity within 10 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:31)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:985)
...

Report flaky test

@stianst stianst merged commit 2f67aa1 into keycloak:release/22.0 Sep 27, 2023
@stianst stianst deleted the backport-22.0-23512 branch September 27, 2023 13:07
@stianst stianst mentioned this pull request Nov 14, 2023
Closed
@stianst stianst mentioned this pull request May 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pskopek pskopek pskopek approved these changes

+1 more reviewer
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

flaky-test team/ui

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@stianst @pskopek