Skip to content

Always check storage access before placing test cookie - #23558

Merged
edewit merged 1 commit into
keycloak:release/22.0from
jonkoops:backport-22839
Sep 27, 2023
Merged

Always check storage access before placing test cookie#23558
edewit merged 1 commit into
keycloak:release/22.0from
jonkoops:backport-22839

Conversation

@jonkoops

Copy link
Copy Markdown
Contributor

Backports #22839

@jonkoops
jonkoops requested review from a team as code owners September 27, 2023 11:41
@ghost ghost added team/ui labels Sep 27, 2023
@edewit
edewit enabled auto-merge (squash) September 27, 2023 11:42
@cypress

cypress Bot commented Sep 27, 2023

Copy link
Copy Markdown

Passing run #9127 ↗︎

0 527 48 0 Flakiness 0

Details:

Merge 18843e3 into 1e4f284...
Project: Keycloak Admin UI Commit: a0d3511bc9 ℹ️
Status: Passed Duration: 15:57 💡
Started: Sep 27, 2023 11:50 AM Ended: Sep 27, 2023 12:06 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@ghost ghost added the flaky-test label Sep 27, 2023

@ghost ghost left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@ghost

ghost commented Sep 27, 2023

Copy link
Copy Markdown

Unreported flaky test detected

If the below flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.x509.X509BrowserCRLTest#loginSuccessWithCRLSignedWithIntermediateCA3FromTruststore

Keycloak CI - FIPS IT (strict)

java.lang.RuntimeException: Could not create statement
	at org.jboss.arquillian.junit.Arquillian.methodBlock(Arquillian.java:313)
	at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
...

Report flaky test

@ghost ghost left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@ghost

ghost commented Sep 27, 2023

Copy link
Copy Markdown

Unreported flaky test detected

If the below flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.x509.X509BrowserCRLTest#loginSuccessWithCRLSignedWithIntermediateCA3FromTruststore

Keycloak CI - FIPS IT (strict)

java.lang.RuntimeException: Could not create statement
	at org.jboss.arquillian.junit.Arquillian.methodBlock(Arquillian.java:313)
	at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
...

Report flaky test

@cypress

cypress Bot commented Sep 27, 2023

Copy link
Copy Markdown

Passing run #9128 ↗︎

0 527 48 0 Flakiness 0

Details:

Always check storage access before placing test cookie (#23558)
Project: Keycloak Admin UI Commit: 1fd2bbec25
Status: Passed Duration: 18:36 💡
Started: Sep 27, 2023 2:33 PM Ended: Sep 27, 2023 2:52 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@jonkoops
jonkoops deleted the backport-22839 branch September 27, 2023 14:57
@stianst stianst mentioned this pull request Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants