Skip to content

Add setup erase command to example for adding more RPMs to the server container - #23639

Merged
vmuzikar merged 1 commit into
keycloak:mainfrom
ASzc:issue_23637
Oct 3, 2023
Merged

Add setup erase command to example for adding more RPMs to the server container#23639
vmuzikar merged 1 commit into
keycloak:mainfrom
ASzc:issue_23637

Conversation

@ASzc

@ASzc ASzc commented Oct 2, 2023

Copy link
Copy Markdown
Contributor

Closes #23637

@ASzc
ASzc requested review from a team as code owners October 2, 2023 15:41
@ghost ghost added the team/cloud-native label Oct 2, 2023
@vmuzikar
vmuzikar requested a review from shawkins October 2, 2023 16:24
@SomeDeveloper13

SomeDeveloper13 commented Oct 2, 2023

Copy link
Copy Markdown

@ASzc - When I tested this locally on my windows machine with Docker Desktop, this appears to have fixed the issue.
image

It also fixed the HOME environment variable:
image

@shawkins shawkins left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, testing the old method with plain docker the container comes up for me but running a docker exec with whoami say it can't find the 1000 user. With the new one it reports keycloak.

@vmuzikar vmuzikar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ASzc Thanks! Approving based on @shawkins' review.

@ASzc Can you please prepare a backport to 22?

@ASzc

ASzc commented Oct 3, 2023

Copy link
Copy Markdown
Contributor Author

@vmuzikar Backport branch: #23668

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Some container implementations don't work with the documented additional RPM install procedure

4 participants