Tolerate secrets being missing (22.0) - #23741
Conversation
|
Having written this, I thought I would need to know if there were missing secrets for the logic to work, but actually, I didn't. Everything for updating the status with the missing secret names could also be removed from this PR if you want it to be really small. |
The changes look good, they will work fine for not optional secrets. Do you care about the optional case?
Probably best to remove from this pr. Adding this would need to tracked separately as we don't have that on main either. |
|
Done, now its tiny :) |
If any secret was missing, the reconcile would error out. After doing this a number of times, the controller would stop trying and end up in a state where the operator would need restarting, or the resource would need recreating, to continue reconciliation. This fix stops the reconcile from erroring out so the operator will reconcile continuously until the secrets are all present. Fixes keycloak#22170
vmuzikar
left a comment
There was a problem hiding this comment.
LGTM, I think we don’t need to consider the optional Secrets here to keep it simple. This is fixed in main.
|
Thank you @Jamstah! :) |
Passing run #9263 ↗︎Details:
Review all test suite changes for PR #23741 ↗︎ |
|||||||||||||||
If any secret was missing, the reconcile would error out. After doing this a number of times, the controller would stop trying and end up in a state where the operator would need restarting, or the resource would need recreating, to continue reconciliation.
This fix stops the reconcile from erroring out so the operator will reconcile continuously until the secrets are all present.
The fix is different than the fix for 23.0 because 23.0 has changed how secrets are handled.
Fixes #22170