Skip to content

fix: remove common-compress - #23745

Merged
vmuzikar merged 1 commit into
keycloak:mainfrom
shawkins:iss23331-forward
Oct 5, 2023
Merged

fix: remove common-compress#23745
vmuzikar merged 1 commit into
keycloak:mainfrom
shawkins:iss23331-forward

Conversation

@shawkins

@shawkins shawkins commented Oct 5, 2023

Copy link
Copy Markdown
Contributor

forward port of #23744

closes #23331

@shawkins
shawkins requested review from a team as code owners October 5, 2023 14:32
@ghost ghost added team/cloud-native labels Oct 5, 2023
@vmuzikar
vmuzikar enabled auto-merge (squash) October 5, 2023 14:55
@vmuzikar
vmuzikar merged commit f100aa7 into keycloak:main Oct 5, 2023
@ghost ghost added the flaky-test label Oct 5, 2023
This was referenced Oct 5, 2023
Closed
Closed
Closed
Closed
ghost
ghost reviewed Oct 5, 2023
View reviewed changes

@ghost ghost left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@ghost

ghost commented Oct 5, 2023

Copy link
Copy Markdown

Unreported flaky test detected

If the below flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.ui.account2.UpdateEmailTest#updateEmailLinkVisibleWithUpdateEmailActionEnabledAndRegistrationEmailAsUsernameAndEditUsernameNotAllowed

Keycloak CI - Account Console IT (firefox)

org.awaitility.core.ConditionTimeoutException: Assertion condition defined as a org.keycloak.testsuite.util.URLAssert URL expected to begin with: https://localhost:8543/auth/realms/test/protocol/openid-connect/auth ; actual URL: https://localhost:8543/auth/realms/test/account/#/personal-info within 10 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:31)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:985)
...

Report flaky test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abstractj abstractj abstractj approved these changes
@vmuzikar vmuzikar vmuzikar approved these changes
+1 more reviewer
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

flaky-test team/cloud-native

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CVE-2023-42503 - Improper Input Validation vulnerability in org.apache.commons:commons-compress

3 participants

@shawkins @abstractj @vmuzikar