Skip to content

Don't use top-level await for storage access checks #23991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jonkoops merged 1 commit into from
Oct 14, 2023
Merged

Don't use top-level await for storage access checks #23991

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 12 additions & 8 deletions services/src/main/resources/org/keycloak/protocol/oidc/endpoints/3p-cookies-step1.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,19 @@
</head>
<body>
<script type="module">
// Check if the browser has granted us access to 3rd-party storage (such as cookies).
const hasAccess = await hasStorageAccess();
checkStorageAccess();

async function checkStorageAccess() {
// Check if the browser has granted us access to 3rd-party storage (such as cookies).
const hasAccess = await hasStorageAccess();

if (hasAccess) {
// If so, attempt to place a cookie to test this assumption.
attemptWithTestCookie();
} else {
// Otherwise, signal that 3rd-party access is not supported.
signalSupport(false);
if (hasAccess) {
// If so, attempt to place a cookie to test this assumption.
attemptWithTestCookie();
} else {
// Otherwise, signal that 3rd-party access is not supported.
signalSupport(false);
}
}

async function hasStorageAccess() {
Expand Down