Fix for Keycloak 22.0.1 unable to create user with long email address - #23132
Conversation
|
@kaustubh-rh Thanks! Could you please also cherry pick this commit 36dd9cb ? It is in latest Keycloak main and contains the changes needed for moving the stuff to 22.0.3 documentation. So this PR would have 2 commits, which is fine. |
|
@mposolda done |
mposolda
left a comment
There was a problem hiding this comment.
@kaustubh-rh Thanks. Looks good, but there are issues in the changes.adoc file. See inline comments.
| @@ -1,5 +1,16 @@ | |||
| == Migration Changes | |||
|
|
|||
| <<<<<<< HEAD | |||
There was a problem hiding this comment.
There are some issues in this file, which cause the documentation is impossible to build.
Could you please fix it and remove "conflict markers" from this file?
Also I suggest to manually build documentation on your laptop and checking it looks as expected before pushing it into the PR.
There was a problem hiding this comment.
@kaustubh-rh Could you please also add something like this:
=== Migrating to 22.0.4
include::changes-22_0_4.adoc[leveloffset=3]
to file changes.adoc, so the page for 22.0.4 is rendered as well?
|
@mposolda added the same to changes.adoc. Thanks |
mposolda
left a comment
There was a problem hiding this comment.
@kaustubh-rh Thanks! I hope to merge once tests are ok
Passing run #8933 ↗︎Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
|||||||||||||||
Closes #22825