Skip to content

Windows Command - need to use the backward Slash - #23197

Merged
ahus1 merged 1 commit into
keycloak:release/22.0from
ahus1:pr-23196-backport
Sep 13, 2023
Merged

Windows Command - need to use the backward Slash#23197
ahus1 merged 1 commit into
keycloak:release/22.0from
ahus1:pr-23196-backport

Conversation

@ahus1

@ahus1 ahus1 commented Sep 13, 2023

Copy link
Copy Markdown
Member

(cherry picked from commit efe1adc)

Backport of #23196

@ahus1 ahus1 added this to the 22.0.3 milestone Sep 13, 2023
@ahus1 ahus1 self-assigned this Sep 13, 2023
@ahus1
ahus1 marked this pull request as ready for review September 13, 2023 08:21
@ahus1
ahus1 requested a review from a team as a code owner September 13, 2023 08:21
@vmuzikar
vmuzikar requested a review from Pepo48 September 13, 2023 08:41

@vmuzikar vmuzikar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, it's a super simple change, let's merge. LGTM, thanks @ahus1

@vmuzikar
vmuzikar enabled auto-merge (squash) September 13, 2023 08:42
@Pepo48

Pepo48 commented Sep 13, 2023

Copy link
Copy Markdown
Contributor

LGTM.

Note:
Let me use this opportunity to mention that nowadays, modern Windows systems can handle forward slashes on the system level (i.e. file explorer) and even on the command-line interpreter level (depends on which one you use). If we consider just the built-in ones, in PowerShell you are safe to use the forward slashes:
image
Whereas the older Command Prompt can't handle this. It's up to users in the end, which interpreter they use. The fact is that PowerShell is also available in the Microsoft's minimal container images.

The reason I'm mentioning it are the recent discussions about Windows platform improvements and I consider this as an opportunity for an improvement.
When it comes to the documentation, to make it slash agnostic, we can be more specific about the interpreter used in the examples (and eventually end up with a single example for each case regardless of the platform, a bit cleaner docs for free).
When it comes to the distribution, we already know that we need to do something about PicoCLI, which is the common source of this type of issues on the Keycloak end.

@abstractj
abstractj disabled auto-merge September 13, 2023 11:15
@abstractj
abstractj enabled auto-merge (rebase) September 13, 2023 11:15
@ahus1
ahus1 disabled auto-merge September 13, 2023 14:34
@ahus1
ahus1 merged commit 138fbe9 into keycloak:release/22.0 Sep 13, 2023
@cypress

cypress Bot commented Sep 13, 2023

Copy link
Copy Markdown

Passing run #8937 ↗︎

0 527 48 0 Flakiness 0

Details:

Windows Command - need to use the backward Slash (#23196)
Project: Keycloak Admin UI Commit: 138fbe9068
Status: Passed Duration: 15:14 💡
Started: Sep 13, 2023 2:45 PM Ended: Sep 13, 2023 3:01 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@ahus1 ahus1 modified the milestones: 22.0.3, 22.0.4 Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants