Skip to content

Remove Quarkus branding from the Operator log - #24419

Merged
shawkins merged 1 commit into
keycloak:release/22.0from
vmuzikar:quarkus-banner-backport
Oct 31, 2023
Merged

Remove Quarkus branding from the Operator log#24419
shawkins merged 1 commit into
keycloak:release/22.0from
vmuzikar:quarkus-banner-backport

Conversation

@vmuzikar

@vmuzikar vmuzikar commented Oct 31, 2023

Copy link
Copy Markdown
Contributor

Closes #24413

@vmuzikar
Remove Quarkus branding from the Operator log
4529488 
Closes keycloak#24413

Signed-off-by: Václav Muzikář <vmuzikar@redhat.com>
@vmuzikar
vmuzikar requested review from a team as code owners October 31, 2023 10:15
@vmuzikar vmuzikar linked an issue Oct 31, 2023 that may be closed by this pull request
Remove Quarkus branding from the Operator log #24413
Closed
@vmuzikar
vmuzikar requested a review from shawkins October 31, 2023 10:15
shawkins
shawkins approved these changes Oct 31, 2023
View reviewed changes

@shawkins shawkins left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shawkins
shawkins enabled auto-merge (squash) October 31, 2023 10:59
ahus1
ahus1 approved these changes Oct 31, 2023
View reviewed changes

@ahus1 ahus1 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as of @shawkins's review.

@ghost ghost added the flaky-test label Oct 31, 2023
This was referenced Oct 31, 2023
Closed
Closed
ghost
ghost reviewed Oct 31, 2023
View reviewed changes

@ghost ghost left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@ghost

ghost commented Oct 31, 2023

Copy link
Copy Markdown

Unreported flaky test detected

If the below flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.ui.account2.WelcomeScreenTest#resourcesTest

Keycloak CI - Account Console IT (firefox)

java.lang.AssertionError: Element should be visible expected:<true> but was:<false>
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.failNotEquals(Assert.java:835)
	at org.junit.Assert.assertEquals(Assert.java:120)
	at org.keycloak.testsuite.util.UIAssert.assertElementVisible(UIAssert.java:47)
...

Report flaky test

ghost
ghost reviewed Oct 31, 2023
View reviewed changes

@ghost ghost left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@ghost

ghost commented Oct 31, 2023

Copy link
Copy Markdown

Unreported flaky test detected

If the below flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.ui.account2.WelcomeScreenTest#resourcesTest

Keycloak CI - Account Console IT (firefox)

java.lang.AssertionError: Element should be visible expected:<true> but was:<false>
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.failNotEquals(Assert.java:835)
	at org.junit.Assert.assertEquals(Assert.java:120)
	at org.keycloak.testsuite.util.UIAssert.assertElementVisible(UIAssert.java:47)
...

Report flaky test

@shawkins
shawkins merged commit 7b79256 into keycloak:release/22.0 Oct 31, 2023
@cypress

cypress Bot commented Oct 31, 2023

Copy link
Copy Markdown

1 flaky test on run #9648 ↗︎

0 527 48 0 Flakiness 1

Details:

Remove Quarkus branding from the Operator log (#24419)
Project: Keycloak Admin UI Commit: 7b79256754
Status: Passed Duration: 15:57 💡
Started: Oct 31, 2023 6:49 PM Ended: Oct 31, 2023 7:05 PM
Flakiness  cypress/e2e/sessions_test.spec.ts • 1 flaky test • chrome

View Output Video

Test Artifacts
Sessions test > revocation > Check if notBefore saved Output Screenshots

Review all test suite changes for PR #24419 ↗︎

@stianst stianst mentioned this pull request Nov 14, 2023
Closed
@vmuzikar
vmuzikar deleted the quarkus-banner-backport branch December 8, 2023 11:30
@stianst stianst mentioned this pull request May 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shawkins shawkins shawkins approved these changes
@ahus1 ahus1 ahus1 approved these changes
+1 more reviewer
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

flaky-test team/cloud-native

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove Quarkus branding from the Operator log

3 participants

@vmuzikar @shawkins @ahus1