Skip to content

Fix broken links - #24476

Merged
ahus1 merged 1 commit into
keycloak:mainfrom
andymunro:501
Nov 13, 2023
Merged

Fix broken links#24476
ahus1 merged 1 commit into
keycloak:mainfrom
andymunro:501

Conversation

@andymunro

@andymunro andymunro commented Nov 1, 2023

Copy link
Copy Markdown
Contributor

@stianst, @pedroigor Can you review this change, which fixes a broken links. The links to quick starts don't exist yet, but I believe these are the planned URLs.

@mposolda Can you verify?

@andymunro
andymunro requested a review from a team as a code owner November 1, 2023 20:06
@andymunro

Copy link
Copy Markdown
Contributor Author

We need to update this with RHBK quick starts once we have them.

@andymunro
andymunro force-pushed the 501 branch 2 times, most recently from ee1fd49 to c6b64b6 Compare November 13, 2023 02:20

@ahus1 ahus1 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR. I removed changes around the quickstarts, as the the description ("Spring") didn't match the contents of the link ("JAXRS"). I also talked to Stian and while not all quickstarts will be available for RHBK, those listed will probably be available.

Let's merge and backport the other changes, and double-check once the quickstart repo has been updated.

@ahus1
ahus1 merged commit bf17fcc into keycloak:main Nov 13, 2023
@ahus1 ahus1 added this to the 22.0.6 milestone Nov 13, 2023
@ahus1

ahus1 commented Nov 13, 2023

Copy link
Copy Markdown
Member

@andymunro - please create a backport for this PR. Thanks!

@andymunro

andymunro commented Nov 13, 2023

Copy link
Copy Markdown
Contributor Author

@ahus1 Do we need to ask @stianst to remove the block on merges, so I can backport it?

@ahus1

ahus1 commented Nov 13, 2023

Copy link
Copy Markdown
Member

@andymunro - you can prepare the PR regardless of the blocked branch. Only to merge it we then need Stian.

ahus1 pushed a commit to andymunro/keycloak that referenced this pull request Nov 13, 2023
(cherry picked from commit bf17fcc)

Signed-off-by: andymunro <48995441+andymunro@users.noreply.github.com>
@ahus1 ahus1 mentioned this pull request Nov 13, 2023
stianst pushed a commit that referenced this pull request Nov 14, 2023
(cherry picked from commit bf17fcc)

Signed-off-by: andymunro <48995441+andymunro@users.noreply.github.com>
@stianst stianst mentioned this pull request Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants