Add attributes.adoc for guides to share common attributes - #24519
Merged
Conversation
stianst
commented
Nov 3, 2023
stianst
force-pushed
the
guides-attributes
branch
2 times, most recently
from
November 6, 2023 09:04
0a4e787 to
6f4b9be
Compare
stianst
marked this pull request as ready for review
November 6, 2023 09:04
stianst
commented
Nov 6, 2023
stianst
force-pushed
the
guides-attributes
branch
from
November 7, 2023 05:04
3956cfe to
a5ea82c
Compare
stianst
force-pushed
the
guides-attributes
branch
from
November 7, 2023 05:56
a5ea82c to
0aad5f3
Compare
ahus1
approved these changes
Nov 8, 2023
ahus1
left a comment
Member
There was a problem hiding this comment.
Thank you for these changes, they look good to me. I saw that some "Keycloak CR" occurrences weren't replaced, I assume this was done on purpose.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding support for attributes.adoc to set shared attributes throughout guides, and use {project_name} in new guides like we are doing for the old documentation format.
Updated a few places in the old docs where we didn't use {project_name}
PR for the website to support loading attributes from attributes.adoc when parsing guide attributes (titles/descriptions) here: keycloak/keycloak-web#429