Addressing Server Admin review comments - #24671
Conversation
There was a problem hiding this comment.
@andymunro - your PR references a GitHub issue which is not related to the PR. GitHub PRs can only reference GitHub issues, not internal JIRA issues. Please duplicate the JIRA issue to a public GitHub issue first so it is clear what you intent to change.
UPDATE: the commit in this PR doesn't contain a signoff, please add this as well. See https://www.keycloak.org/2023/10/dco for the details.
vaceksimon
left a comment
There was a problem hiding this comment.
After these corrections it's ready for merge. Good job Andy
There was a problem hiding this comment.
The picture from an older version of Keycloak I had in mind was user-profile-select-options-custom-validator.png. This picture is fine as it is.
|
@ahus1 @vaceksimon Comments addressed and signed off to correct Jira. |
ahus1
left a comment
There was a problem hiding this comment.
DCO looks good to me. Waiting for review of @vaceksimon
vaceksimon
left a comment
There was a problem hiding this comment.
LGTM! Ready to merge @ahus1
|
@ahus1 I can fix one more issue with this guide related to the Account Console broken link |
Closes keycloak#24643 Signed-off-by: AndyMunro <amunro@redhat.com>
|
@ahus1 I fixed that last broken link issue. Ready to merge. |
|
@andymunro for future changes, when you add more changes, please only rebase when there is a need, for example when conflicts exists. Otherwise it makes it difficult for me to see which changes you added in your final changes. |
Closes #24643
@ahus1 @vaceksimon Can you verify this. This addressed most issues you raised.