Skip to content

Revert "Ignore JDBC Drivers artifacts" - #24938

Merged
vmuzikar merged 1 commit into
mainfrom
revert-22443-ignoreJdbc
Nov 22, 2023
Merged

Revert "Ignore JDBC Drivers artifacts"#24938
vmuzikar merged 1 commit into
mainfrom
revert-22443-ignoreJdbc

Conversation

@vmuzikar

@vmuzikar vmuzikar commented Nov 22, 2023

Copy link
Copy Markdown
Contributor

Reverts #22443

Simple kc.sh start-dev fails with:

ERROR: Unexpected error when starting the server in (development) mode
Error details:
java.lang.RuntimeException: Failed to start quarkus
	at io.quarkus.runner.ApplicationImpl.<clinit>(Unknown Source)
	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
	at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:499)
	at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:480)
	at io.quarkus.runtime.Quarkus.run(Quarkus.java:70)
	at org.keycloak.quarkus.runtime.KeycloakMain.start(KeycloakMain.java:117)
	at org.keycloak.quarkus.runtime.cli.command.AbstractStartCommand.run(AbstractStartCommand.java:33)
	at picocli.CommandLine.executeUserObject(CommandLine.java:2026)
	at picocli.CommandLine.access$1500(CommandLine.java:148)
	at picocli.CommandLine$RunLast.executeUserObjectOfLastSubcommandWithSameParent(CommandLine.java:2461)
	at picocli.CommandLine$RunLast.handle(CommandLine.java:2453)
	at picocli.CommandLine$RunLast.handle(CommandLine.java:2415)
	at picocli.CommandLine$AbstractParseResultHandler.execute(CommandLine.java:2273)
	at picocli.CommandLine$RunLast.execute(CommandLine.java:2417)
	at picocli.CommandLine.execute(CommandLine.java:2170)
	at org.keycloak.quarkus.runtime.cli.Picocli.parseAndRun(Picocli.java:119)
	at org.keycloak.quarkus.runtime.KeycloakMain.main(KeycloakMain.java:107)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:568)
	at io.quarkus.bootstrap.runner.QuarkusEntryPoint.doRun(QuarkusEntryPoint.java:61)
	at io.quarkus.bootstrap.runner.QuarkusEntryPoint.main(QuarkusEntryPoint.java:32)
Caused by: java.lang.ClassNotFoundException: io.quarkus.jdbc.mssql.runtime.MsSQLAgroalConnectionConfigurer
	at java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:641)
	at java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:188)
	at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:525)
	at io.quarkus.bootstrap.runner.RunnerClassLoader.loadClass(RunnerClassLoader.java:115)
	at io.quarkus.bootstrap.runner.RunnerClassLoader.loadClass(RunnerClassLoader.java:65)
	at java.base/java.lang.Class.forName0(Native Method)
	at java.base/java.lang.Class.forName(Class.java:467)
	at io.quarkus.jdbc.mssql.runtime.MsSQLAgroalConnectionConfigurer_Bean.<init>(Unknown Source)
	at io.quarkus.arc.setup.Default_ComponentsProvider.addBeans2(Unknown Source)
	at io.quarkus.arc.setup.Default_ComponentsProvider.getComponents(Unknown Source)
	at io.quarkus.arc.impl.ArcContainerImpl.<init>(ArcContainerImpl.java:125)
	at io.quarkus.arc.Arc.initialize(Arc.java:39)
	at io.quarkus.arc.runtime.ArcRecorder.initContainer(ArcRecorder.java:47)
	at io.quarkus.deployment.steps.ArcProcessor$generateResources844392269.deploy_0(Unknown Source)
	at io.quarkus.deployment.steps.ArcProcessor$generateResources844392269.deploy(Unknown Source)
	... 25 more

We need to investigate further, reverting for now given close 23 release.

@vmuzikar
vmuzikar requested a review from mabartos November 22, 2023 17:58
@vmuzikar
vmuzikar requested review from a team as code owners November 22, 2023 17:58
@vmuzikar vmuzikar mentioned this pull request Nov 22, 2023
Closed
@vmuzikar
Revert "Ignore JDBC Drivers artifacts (#22443)"
9d37bad 
This reverts commit d0bfbde.

Signed-off-by: Václav Muzikář <vmuzikar@redhat.com>
@vmuzikar
vmuzikar force-pushed the revert-22443-ignoreJdbc branch from b0573e6 to 9d37bad Compare November 22, 2023 18:05
@vmuzikar
vmuzikar enabled auto-merge (squash) November 22, 2023 18:05
@cypress

cypress Bot commented Nov 22, 2023 •
edited
Loading

Copy link
Copy Markdown

2 failed and 1 flaky tests on run #9927 ↗︎

2 1072 98 0 Flakiness 1

Details:

Revert "Ignore JDBC Drivers artifacts (#22443)" (#24938)
Project: Keycloak Admin UI Commit: 33dd830914
Status: Failed Duration: 10:10 💡
Started: Nov 23, 2023 12:25 AM Ended: Nov 23, 2023 12:36 AM
Failed  cypress/e2e/realm_test.spec.ts • 2 failed tests • firefox

View Output

Test Artifacts
Realm tests > Should delete Test Disabled realm Screenshots
Realm tests > should create realm from new a realm Screenshots
Flakiness  cypress/e2e/clients_test.spec.ts • 1 flaky test • chrome

View Output

Test Artifacts
Clients test > Client details - Client scopes subtab > Should search non-existent client scope by name Test Replay Screenshots

Review all test suite changes for PR #24938 ↗︎

@vmuzikar
vmuzikar merged commit 33dd830 into main Nov 22, 2023
@vmuzikar
vmuzikar deleted the revert-22443-ignoreJdbc branch November 22, 2023 19:11
@ghost ghost added the flaky-test label Nov 22, 2023
@ghost ghost mentioned this pull request Nov 22, 2023
Closed
ShefeeqPM pushed a commit to ShefeeqPM/keycloak that referenced this pull request Jan 27, 2024
@vmuzikar @ShefeeqPM
Revert "Ignore JDBC Drivers artifacts (keycloak#22443)" (keycloak#24938)
8d31c35 
This reverts commit d0bfbde.

Signed-off-by: Václav Muzikář <vmuzikar@redhat.com>
Signed-off-by: ShefeeqPM <86718986+ShefeeqPM@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahus1 ahus1 ahus1 approved these changes
@mabartos mabartos Awaiting requested review from mabartos

Assignees

No one assigned

Labels

flaky-test team/cloud-native

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vmuzikar @ahus1