Skip to content

fix exception when user does not have view-realm role - #24036

Merged
ssilvert merged 1 commit into
keycloak:mainfrom
jackie-linz:fix/federated-user-link
Oct 23, 2023
Merged

fix exception when user does not have view-realm role#24036
ssilvert merged 1 commit into
keycloak:mainfrom
jackie-linz:fix/federated-user-link

Conversation

@jackie-linz

Copy link
Copy Markdown
Contributor

Closes #23954

@jackie-linz
jackie-linz requested a review from a team as a code owner October 16, 2023 21:41
@ghost ghost added the team/ui label Oct 16, 2023

@jonkoops jonkoops left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cypress

cypress Bot commented Oct 16, 2023

Copy link
Copy Markdown

2 flaky tests on run #9415 ↗︎

0 527 48 0 Flakiness 2

Details:

Merge 38f32e2 into 1cd20e0...
Project: Keycloak Admin UI Commit: 09d63048b4 ℹ️
Status: Passed Duration: 12:27 💡
Started: Oct 16, 2023 10:17 PM Ended: Oct 16, 2023 10:29 PM
Flakiness  clients_test.spec.ts • 1 flaky test • chrome

View Output Video

Test Artifacts
Clients test > Accessibility tests for clients > Check a11y violations on load/ clients list tab Test Replay Output Screenshots
Flakiness  realm_settings_general_tab_test.spec.ts • 1 flaky test • chrome

View Output Video

Test Artifacts
Realm settings general tab tests > Test all general tab switches Test Replay Output Screenshots

Review all test suite changes for PR #24036 ↗︎

@thomasdarimont

thomasdarimont commented Oct 17, 2023

Copy link
Copy Markdown
Contributor

@jonkoops is this also a candidate for 22.0.5 (release/22.0)?

@ssilvert ssilvert added this to the 22.0.6 milestone Oct 23, 2023
@ssilvert
ssilvert merged commit 03a8f05 into keycloak:main Oct 23, 2023
@ssilvert

Copy link
Copy Markdown
Contributor

@jonkoops is this also a candidate for 22.0.5 (release/22.0)?

@thomasdarimont I marked this for 22.0.6 as we are getting close to the release of 22.0.5.

@jackie-linz
jackie-linz deleted the fix/federated-user-link branch October 23, 2023 19:45
@jonkoops jonkoops removed this from the 22.0.6 milestone Oct 23, 2023
jonkoops pushed a commit to jonkoops/keycloak that referenced this pull request Oct 23, 2023
@jonkoops

Copy link
Copy Markdown
Contributor

@ssilvert I've removed the milestone from this PR, as there is already one on the linked issue. I also went ahead and created a backport for this, so we could still land this for 22.0.5 if you like: #24231

@jonkoops

Copy link
Copy Markdown
Contributor

Thanks for landing this @jackie-linz!

jonkoops added a commit that referenced this pull request Oct 23, 2023
Closes #23954

Co-authored-by: jackie-linz <120340761+jackie-linz@users.noreply.github.com>
@stianst stianst mentioned this pull request Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FederatedUserLink errors when user does not have view-realm role

4 participants