Enhance user profile attribute form UX - #24083
Merged
Merged
Conversation
1 flaky test on run #9476 ↗︎Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Realm settings general tab tests > Test all general tab switches |
Test Replay
Output
Screenshots
|
|
Review all test suite changes for PR #24083 ↗︎
Enhances the user experience for the create and edit form for User Profile attribute by making the following changes: - Prevents the scopes from being persisted if an attribute can always be shown. - Hides the scopes if 'Always' is selected, as the control is not interactive. - Sets the attribute to be editable by admins by default. Closes keycloak#24081 Closes keycloak#23790 Co-authored-by: Pedro Igor <pigor.craveiro@gmail.com>
jonkoops
marked this pull request as ready for review
October 18, 2023 15:48
edewit
approved these changes
Oct 18, 2023
jonkoops
added a commit
to jonkoops/keycloak
that referenced
this pull request
Oct 18, 2023
Enhances the user experience for the create and edit form for User Profile attribute by making the following changes: - Prevents the scopes from being persisted if an attribute can always be shown. - Hides the scopes if 'Always' is selected, as the control is not interactive. - Sets the attribute to be editable by admins by default. Closes keycloak#24081 Closes keycloak#23790 Co-authored-by: Pedro Igor <pigor.craveiro@gmail.com>
jonkoops
added a commit
that referenced
this pull request
Oct 19, 2023
Enhances the user experience for the create and edit form for User Profile attribute by making the following changes: - Prevents the scopes from being persisted if an attribute can always be shown. - Hides the scopes if 'Always' is selected, as the control is not interactive. - Sets the attribute to be editable by admins by default. Closes #24081 Closes #23790 Co-authored-by: Pedro Igor <pigor.craveiro@gmail.com>
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhances the user experience for the create and edit form for User Profile attribute by making the following changes:
Closes #24081
Closes #23790