Skip to content

added default field type - #24172

Merged
ssilvert merged 2 commits into
keycloak:mainfrom
edewit:issue-23911
Oct 20, 2023
Merged

added default field type#24172
ssilvert merged 2 commits into
keycloak:mainfrom
edewit:issue-23911

Conversation

@edewit

@edewit edewit commented Oct 20, 2023

Copy link
Copy Markdown
Contributor

default will now render a text input
and a multiline input for when there is no inputType, which makes more sense then a multi select with no options

fixes: #23911

@edewit
edewit requested a review from a team as a code owner October 20, 2023 08:29
@ghost ghost added the team/ui label Oct 20, 2023
@edewit

edewit commented Oct 20, 2023

Copy link
Copy Markdown
Contributor Author

image

@cypress

cypress Bot commented Oct 20, 2023

Copy link
Copy Markdown

3 flaky tests on run #9527 ↗︎

0 527 48 0 Flakiness 3

Details:

Merge 82edc0a into 1837b44...
Project: Keycloak Admin UI Commit: fe3d722994 ℹ️
Status: Passed Duration: 11:35 💡
Started: Oct 20, 2023 4:46 PM Ended: Oct 20, 2023 4:58 PM
Flakiness  realm_settings_general_tab_test.spec.ts • 1 flaky test • chrome

View Output Video

Test Artifacts
Realm settings general tab tests > Test all general tab switches Test Replay Output Screenshots
Flakiness  clients_test.spec.ts • 2 flaky tests • chrome

View Output Video

Test Artifacts
Clients test > Keys tab test > Generate new keys Test Replay Output Screenshots
Clients test > Accessibility tests for clients > Check a11y violations on load/ clients list tab Test Replay Output Screenshots

Review all test suite changes for PR #24172 ↗︎

@ssilvert ssilvert left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

default will now render a multiline input
which makes more sense then a multi select
with no options

fixes: keycloak#23911
@ssilvert
ssilvert merged commit bafc6da into keycloak:main Oct 20, 2023
edewit added a commit to edewit/keycloak that referenced this pull request Oct 23, 2023
* added default field type

default will now render a multiline input
which makes more sense then a multi select
with no options

fixes: keycloak#23911

* changed to only render multi line when needed
ssilvert pushed a commit that referenced this pull request Oct 23, 2023
* added default field type

default will now render a multiline input
which makes more sense then a multi select
with no options

fixes: #23911

* changed to only render multi line when needed
@stianst stianst mentioned this pull request Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

User profile attribute default render should be ordinary input

2 participants