Skip to content

Upgrade to Quarkus 3.2.12 - #28894

Merged
vmuzikar merged 2 commits into
keycloak:release/22.0from
vmuzikar:quarkus-3212
May 2, 2024
Merged

Upgrade to Quarkus 3.2.12#28894
vmuzikar merged 2 commits into
keycloak:release/22.0from
vmuzikar:quarkus-3212

Conversation

@vmuzikar

@vmuzikar vmuzikar commented Apr 18, 2024

Copy link
Copy Markdown
Contributor

Closes #28886

On hold until RHBQ 3.2.12 is available.

@vmuzikar vmuzikar added the status/hold PR should not be merged. On hold for later. label Apr 22, 2024
@vmuzikar

Copy link
Copy Markdown
Contributor Author

@ASzc Needed to remove the netty overrides that were introduced in #24608 to align with Quarkus and resolve some ClassDefNotFound. Not sure what was the context behind #24608 but we expect Quarkus to take care of productization.

@ASzc

ASzc commented Apr 22, 2024

Copy link
Copy Markdown
Contributor

Should be ok to remove. It was required because RHBQ's BOM at the time had an old netty version lacking a CVE fix

@keycloak-github-bot keycloak-github-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot

Copy link
Copy Markdown

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.ui.account2.WelcomeScreenTest#clickLogoTest

Keycloak CI - Account Console IT (firefox)

java.lang.AssertionError: Expected WelcomeScreen but was Keycloak Account Management (https://localhost:8543/auth/realms/test/account/)
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.keycloak.testsuite.page.AbstractPage.assertCurrent(AbstractPage.java:110)
	at jdk.internal.reflect.GeneratedMethodAccessor106.invoke(Unknown Source)
...

Report flaky test

Closes keycloak#28886

Signed-off-by: Václav Muzikář <vmuzikar@redhat.com>
Signed-off-by: Václav Muzikář <vmuzikar@redhat.com>

@keycloak-github-bot keycloak-github-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot

Copy link
Copy Markdown

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.forms.BrowserFlowTest#testAlternativeNonInteractiveExecutorInSubflow

Keycloak CI - Forms IT (firefox)

org.openqa.selenium.TimeoutException: 
Navigation timed out after 10000 ms
Build info: version: '3.14.0', revision: 'aacccce0', time: '2018-08-02T20:19:58.91Z'
System info: host: 'fv-az1019-750', ip: '10.1.0.24', os.name: 'Linux', os.arch: 'amd64', os.version: '6.5.0-1018-azure', java.version: '17.0.10'
Driver info: org.openqa.selenium.firefox.FirefoxDriver
...

Report flaky test

@vmuzikar
vmuzikar marked this pull request as ready for review May 2, 2024 07:18
@vmuzikar
vmuzikar requested review from a team as code owners May 2, 2024 07:18
@vmuzikar

vmuzikar commented May 2, 2024

Copy link
Copy Markdown
Contributor Author

This should be now ready, no need to hold it for RHBQ any longer.

@vmuzikar vmuzikar removed the status/hold PR should not be merged. On hold for later. label May 2, 2024
@vmuzikar
vmuzikar merged commit a24099d into keycloak:release/22.0 May 2, 2024
@vmuzikar
vmuzikar deleted the quarkus-3212 branch May 2, 2024 07:20
cgeorgilakis pushed a commit to eosc-kc/keycloak that referenced this pull request Jul 15, 2024
cgeorgilakis pushed a commit to eosc-kc/keycloak that referenced this pull request Oct 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants