Relax checking of messages - #28912
Merged
hmlnarik merged 1 commit intoApr 19, 2024
Merged
Conversation
Related to: keycloak#28873 Fixes: keycloak#28911 Signed-off-by: Hynek Mlnarik <hmlnarik@redhat.com>
hmlnarik
force-pushed
the
28911-clients-saml-test-spec-ts-fails-often-main
branch
from
April 19, 2024 10:29
9e9ec65 to
72bc652
Compare
hmlnarik
enabled auto-merge (rebase)
April 19, 2024 10:48
jonkoops
reviewed
Apr 19, 2024
| .should("match", message); | ||
|
|
||
| if (closeNotification) { | ||
| this.#getAlertsContainer().find("button").last().click({ force: true }); |
Contributor
There was a problem hiding this comment.
This looks like it might close an unrelated alert, but probably fine,
jonkoops
approved these changes
Apr 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to: #28873
Fixes: #28911