Skip to content

Improve procedure for handling open transactions#29748

Merged
ahus1 merged 1 commit into
keycloak:mainfrom
k-tamura:patch-5
Jun 12, 2024
Merged

Improve procedure for handling open transactions#29748
ahus1 merged 1 commit into
keycloak:mainfrom
k-tamura:patch-5

Conversation

@k-tamura

@k-tamura k-tamura commented May 21, 2024

Copy link
Copy Markdown
Contributor

This operation should not be necessary in the Quarkus version.

@k-tamura k-tamura requested a review from a team as a code owner May 21, 2024 14:45
ahus1
ahus1 requested changes May 21, 2024
View reviewed changes

@ahus1 ahus1 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for looking into this.

This would still be necessary if a deployment has XA transactions enabled. But the path is wrong, as it is set for Quarkus to a different value:

keycloak/quarkus/runtime/src/main/resources/application.properties

Line 38 in c4fdf1c

quarkus.transaction-manager.object-store.directory=${kc.home.dir:default}${file.separator}data${file.separator}transaction-logs

See

keycloak/docs/guides/server/db.adoc

Lines 270 to 283 in 9db1443

== Using Database Vendors with XA transaction support
{project_name} uses non-XA transactions and the appropriate database drivers by default.
If you wish to use the XA transaction support offered by your driver, enter the following command:
<@kc.build parameters="--db=<vendor> --transaction-xa-enabled=true"/>
{project_name} automatically chooses the appropriate JDBC driver for your vendor.
NOTE: Certain vendors, such as Azure SQL and MariaDB Galera, do not support or rely on the XA transaction mechanism.
XA recovery defaults to enabled and will use the file system location `KEYCLOAK_HOME/data/transaction-logs` to store transaction logs.
NOTE: Enabling XA transactions in a containerized environment does not fully support XA recovery unless stable storage is available at that path.
for the current state of XA transactions in KC25.

Note that XA transactions have been enabled by default in the Quarkus versions up until KC24 (including), and have been disabled by default in KC25 (see #27308).

@ahus1 ahus1 self-assigned this May 21, 2024
@k-tamura k-tamura force-pushed the patch-5 branch 2 times, most recently from 00f101c to 5ba1468 Compare June 12, 2024 01:55
@k-tamura

k-tamura commented Jun 12, 2024

Copy link
Copy Markdown
Contributor Author

@ahus1
Could you check my new commit?

@ahus1

ahus1 commented Jun 12, 2024

Copy link
Copy Markdown
Member

@k-tamura - thank you, the updated docs match Keycloak's behavior.

To be able to merge this PR, I ask you to squash those commits, and add a Sign-off to the commit. See the file CONTRIBUTING.md in this repository on how to do this. The sign-off shows that you comply with the contribution guidelines to this repository.

@k-tamura
Improve procedure for handling open transactions
e2c42ec 
Signed-off-by: k-tamura <ktamura.biz.80@gmail.com>
@k-tamura

k-tamura commented Jun 12, 2024

Copy link
Copy Markdown
Contributor Author

@ahus1
Thank you. I squashed, could you check again?

@k-tamura k-tamura changed the title Delete operation for transaction handling Improve procedure for handling open transactions Jun 12, 2024
ahus1
ahus1 approved these changes Jun 12, 2024
View reviewed changes

@ahus1 ahus1 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this fix and making the docs accurate!

@ahus1 ahus1 merged commit d969676 into keycloak:main Jun 12, 2024
@ahus1

ahus1 commented Jun 12, 2024

Copy link
Copy Markdown
Member

Thank you - your changes will be part of the next major release of Keycloak (26.0.0)

@k-tamura k-tamura deleted the patch-5 branch June 12, 2024 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahus1 ahus1 ahus1 approved these changes

Assignees

@ahus1 ahus1

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@k-tamura @ahus1