KEYCLOAK-3244: Required Action "Configure Totp" should be "Configure OTP"#2991
Merged
stianst merged 2 commits intokeycloak:masterfrom Jul 7, 2016
Merged
KEYCLOAK-3244: Required Action "Configure Totp" should be "Configure OTP"#2991stianst merged 2 commits intokeycloak:masterfrom
stianst merged 2 commits intokeycloak:masterfrom
Conversation
Contributor
|
#1 We should add migration of existing realms and change the name if alias, name and providerId matches DefaultRequiredActions (this should be done in MigrationModelManager with a MigrateTo2_1_0 class) #2 Let's just keep it as totp for now. We'll probably need to refactor this in the future anyways to make it less hard-coded on otp as two-factor mechanism. |
Contributor
Author
|
OK. I'll implement #1 very soon. |
Contributor
|
Looks like this is ready now? |
Contributor
Author
|
Yes, ready to go. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented the "trivial" fix as indicated on the JIRA. However, there are a few other things to think about.
First, the displayed value actually comes from totp.setName() in DefaultRequiredActions. The value is stored in the database. So for upgraded servers, it will always say "Configure TOTP". That is, unless we want to change it as part of an upgrade script.
Second, the code uses the term "totp" all over the place. I assume that sometimes this is appropriate, but most of the time we really just mean "otp"?